Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isMobilePhone: en-BM matches invalid numbers #2115

Closed
pano9000 opened this issue Dec 6, 2022 · 0 comments · Fixed by #2116
Closed

isMobilePhone: en-BM matches invalid numbers #2115

pano9000 opened this issue Dec 6, 2022 · 0 comments · Fixed by #2116
Labels
🐛 bug pr-raised

Comments

@pano9000
Copy link
Contributor

pano9000 commented Dec 6, 2022

Describe the bug
When passing a phone number that starts with 59 (after the country code), isMobilePhone will match invalid strings as valid

Examples
+14415974653 this should not match
isMobilePhone should return false, due to the additional string part, but currently it returns true.

Similar to #2113, this is caused by a missing end-of-string anchor in the RegExp.

PR with the fix coming in a few moments
pano9000 added a commit to pano9000/validator.js that referenced this issue Dec 6, 2022
@pano9000
fix(isMobilePhone): en-BM missing end-of-string anchor
dd310d4 
that one particular number combination was missing the `$` end-of-string anchor, which caused the bug validatorjs#2115

fixes validatorjs#2115
pano9000 added a commit to pano9000/validator.js that referenced this issue Dec 6, 2022
@pano9000
test(isMobilePhone): add additional invalid test to en-BM
d7a142f 
related to validatorjs#2115
@pano9000 pano9000 mentioned this issue Dec 6, 2022
Merged
2 tasks
pano9000 added a commit to pano9000/validator.js that referenced this issue Jan 28, 2023
@pano9000
fix(isMobilePhone): en-BM missing end-of-string anchor
124f20f 
that one particular number combination was missing the `$` end-of-string anchor, which caused the bug validatorjs#2115

fixes validatorjs#2115
pano9000 added a commit to pano9000/validator.js that referenced this issue Jan 28, 2023
@pano9000
test(isMobilePhone): add additional invalid test to en-BM
b2249b6 
related to validatorjs#2115
profnandaa pushed a commit that referenced this issue Jan 29, 2023
@pano9000
fix(isMobilePhone): Fix en-BM matching invalid numbers due to missing…
c81df18 
… end-of-string anchor (#2116)

fixes #2115
related to #2115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug pr-raised
Projects
None yet
Milestone
No milestone
1 participant
@pano9000