Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isFloat returns false for "-.01" #618

Closed
mdj128 opened this issue Jan 25, 2017 · 1 comment
Closed

isFloat returns false for "-.01" #618

mdj128 opened this issue Jan 25, 2017 · 1 comment
Labels
🐛 bug

Comments

@mdj128
Copy link

mdj128 commented Jan 25, 2017

validator.isFloat("-.01") = false. I'm using version 6.2.0 currently, didn't know if this is expected or has been reported already.
@chriso chriso added the 🐛 bug label Feb 1, 2017
@chriso
Copy link
Collaborator

chriso commented Feb 1, 2017

Thanks for the report.

Given that -.01 is allowed as a literal and is accepted by parseFloat I think it's ok:

> -.01
-0.01
> parseFloat('-.01')
-0.01

Also it looks like isFloat('.01') is true so this is inconsistent behavior.

@chriso chriso closed this as completed in cd92fb3 Feb 1, 2017
janmeier added a commit to sequelize/sequelize that referenced this issue Mar 1, 2017
@janmeier
fix: Remove test that thinks -.123 is not a valid float (see validato…
370dbbb 
…rjs/validator.js#618)
mkaufmaner pushed a commit to mkaufmaner/sequelize that referenced this issue Apr 25, 2017
@janmeier @mkaufmaner
fix: Remove test that thinks -.123 is not a valid float (see validato…
e67b218 
…rjs/validator.js#618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chriso @mdj128