feat(isFQDN): fix tld validation #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
reviewed
Aug 18, 2019
lib/isFQDN.js
Outdated
| } // disallow special characers | ||
|
|
||
|
|
||
| if (/[\u00A9\uFFFD]/.test(tld)) { |
There was a problem hiding this comment.
Is this an exhaustive list or we might be having more characters? And why don't we add them on line 45?
|
Thanks for the PR! 🎉 |
|
First, sorry for this later answer and thank you for reviewing my PR, as you mentioned, I moved the instruction to the previous line. |
|
Sorry on my delay on checking this, I'm going to review it by end of the weekend. Please be on the standby for any changes to be made... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually this commit is related to #1087
The isFQDN feature does not filter some illegal characters like
� or ©