added support for 19 digit cc #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for 19 digit visa and discover
profnandaa
requested changes
Oct 25, 2019
profnandaa
added
the
🧹 needs-update
|
Hi @profnandaa do you want some kind of condition to check the length, and if its 19 characters do the new one, if not original one ? the original one is not just for 16 but also supports shorter ones. is your concern about performance or readability ? if its readability maybe breaking it out to match specific cases would be the best ? I have noticed that sometimes there are valid numbers which would not be valid cc number ( based on this https://www.freeformatter.com/credit-card-number-generator-validator.html ) |
|
@aemarcuss -- got it. Let it be then. Just add the tests and we should be good to go. |
added tests
|
@profnandaa added & passed the tests. |
profnandaa
added
🕑 to-be-reviewed
and removed
🧹 needs-update
|
@profnandaa You reckon this is good to go? |
profnandaa
approved these changes
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for 19 digit visa and discover cc