Fixed pt-PT alpha and alphanumeric validation #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezkemboi
reviewed
Nov 30, 2019
| @@ -13,7 +13,7 @@ export const alpha = { | |||
| 'nn-NO': /^[A-ZÆØÅ]+$/i, | |||
| 'hu-HU': /^[A-ZÁÉÍÓÖŐÚÜŰ]+$/i, | |||
| 'pl-PL': /^[A-ZĄĆĘŚŁŃÓŻŹ]+$/i, | |||
| 'pt-PT': /^[A-ZÃÁÀÂÇÉÊÍÕÓÔÚÜ]+$/i, | |||
| 'pt-PT': /^[A-ZÃÁÀÂÄÇÉÊËÍÏÕÓÔÖÚÜ]+$/i, | |||
There was a problem hiding this comment.
I will look deeper into the research above. But for now, we can add or edit tests for the addition/changes made on this part.
There was a problem hiding this comment.
All right. Since there aren't any tests regarding this locale, I'll write it.
| @@ -43,7 +43,7 @@ export const alphanumeric = { | |||
| 'nl-NL': /^[0-9A-ZÁÉËÏÓÖÜÚ]+$/i, | |||
| 'nn-NO': /^[0-9A-ZÆØÅ]+$/i, | |||
| 'pl-PL': /^[0-9A-ZĄĆĘŚŁŃÓŻŹ]+$/i, | |||
| 'pt-PT': /^[0-9A-ZÃÁÀÂÇÉÊÍÕÓÔÚÜ]+$/i, | |||
| 'pt-PT': /^[0-9A-ZÃÁÀÂÄÇÉÊËÍÏÕÓÔÖÚÜ]+$/i, | |||
There was a problem hiding this comment.
Apply the comment above on this part.
profnandaa
approved these changes
Dec 6, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2009 a new spelling reform abolished the diaeresis diacritical mark from the portuguese language. The agreement, however, decreed that proper names should keep it.
I have made changes to the alpha and alphanumeric validation to accepts every vowel with a diaresis mark. It's a very common use case of my projects have an input field that should holds a user name. That field should only have alpha characters and I would expect that "Schäfer" (my surname) would pass this validation.
The current validator.js version accepts the 'ü' as an alpha character, but not any other vowel with ¨. In order to be consistent it should allow every vowel or none.
✌️