Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added zimbabwe mobile number validation #1315

Merged
merged 2 commits into from
May 27, 2020
Merged

feat: added zimbabwe mobile number validation #1315

merged 2 commits into from
May 27, 2020

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented May 26, 2020

as the last PR got messed up due to the generated files, this one should do fine

@rubiin
Copy link
Member Author

rubiin commented May 26, 2020

@profnandaa i have made a new pr for that issue

@profnandaa
Copy link
Member

profnandaa commented May 27, 2020 •
edited
Loading

So we can close this one. sorry, mistaken.

@profnandaa
Copy link
Member

Looks good, just fix the merge conflict, we should be good.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label May 27, 2020
@rubiin
Copy link
Member Author

rubiin commented May 27, 2020

okay on it , let me fix this real quick

@rubiin
Copy link
Member Author

rubiin commented May 27, 2020

@profnandaa done

@profnandaa profnandaa merged commit 3734367 into validatorjs:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubiin @profnandaa