HOTFIX - Fixed the bug on BA mobile phone regex #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MladenZeljic
changed the title
|
Can fix the merge conflict? |
profnandaa
added
🧹 needs-update
profnandaa
requested changes
Jun 13, 2020
There was a problem hiding this comment.
Oops forgot, can you bring back the rest of the work now, I'd removed it in #1355; rebase with the current master.
profnandaa
added
the
🧹 needs-update
3 tasks
|
ping @MladenZeljic |
Added verification for bosnian mobile phone numbers
Fixed bs locale
Updated locale in readme
Updated the regular expression for bosnian mobile numbers by removing lookbehinds and modifying the expression to keep the right checks for these mobile numbers
MladenZeljic
force-pushed
the
fix/update-for-ba-phone-regex
branch
from
ff4007e
to
1e4a05c
Compare
|
@profnandaa Sorry, I've been busy. Readme, validator and regex should be here. Anything else to add? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the regular expression for bosnian mobile numbers by removing lookbehinds and modifying the expression to keep the right checks for these mobile numbers