Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Italian Electronic Identity Card validator #1384

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Added the Italian Electronic Identity Card validator #1384

merged 4 commits into from
Jul 20, 2020

Conversation

lorenzodb1
Copy link
Contributor

I added support to validate the Italian Identity Card number as described in here.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

lib/isIdentityCard.js Outdated Show resolved Hide resolved
@lorenzodb1
Copy link
Contributor Author

@parasg1999 quick question: as in Italy we have a number for our ID Card and a number that we call 'fiscal code' that's used for tax purposes (https://en.wikipedia.org/wiki/Italian_fiscal_code), would this function cover just the former one or would it cover the latter one too?

@parasg1999
Copy link
Contributor

@lorenzodb1 You can add that in isTaxId if that's what you require.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 9207b04 into validatorjs:master Jul 20, 2020
@profnandaa profnandaa mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants