-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isPassportNumber): added validation for Indonesia (ID) #1498
feat(isPassportNumber): added validation for Indonesia (ID) #1498
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1498 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1277 1277
=======================================
Hits 1276 1276
Misses 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the most part, check my comments below. Thanks for your PR! 🎉
@@ -149,7 +149,9 @@ var _isISO31661Alpha2 = _interopRequireDefault(require("./lib/isISO31661Alpha3") | |||
|
|||
var _isBase = _interopRequireDefault(require("./lib/isBase32")); | |||
|
|||
var _isBase2 = _interopRequireDefault(require("./lib/isBase64")); | |||
var _isBase2 = _interopRequireDefault(require("./lib/isBase58")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since changes in the index.js
file are unrelated, you can leave out this file from the PR.
@@ -2354,11 +2356,13 @@ var phones = { | |||
'be-BY': /^(\+?375)?(24|25|29|33|44)\d{7}$/, | |||
'bg-BG': /^(\+?359|0)?8[789]\d{7}$/, | |||
'bn-BD': /^(\+?880|0)1[13456789][0-9]{8}$/, | |||
'ca-AD': /^(\+376)?[346]\d{5}$/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, also remove the unrelated changes; please re-base correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just work on comments and fix any merge conflicts and this is good to go.
@pandu-supriyono - ping! |
this looks stale and the author has not responded, I will take this if no one is up for it |
@rubiin feel free to take it! There is many more stale PRs, we should probably take care of them |
yeah. lets not make the repo look inactive by stacking up stale prs |
Added a regex for passports of the Republic of Indonesia.
Every few years, the first character increments alphabetically. As of October 2020, only passports starting with A, B, or C have been issued. An eventual update would be in order.
Checklist