Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update es-Co phone number #1541

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Conversation

ezkemboi
Copy link
Member

@ezkemboi ezkemboi commented Nov 30, 2020

Fix #1519

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1541 (55c7dd9) into master (5810e36) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1541   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines         1773      1773           
=========================================
  Hits          1773      1773           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5810e36...55c7dd9. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Dec 1, 2020
@ezkemboi ezkemboi force-pushed the fix-1519 branch 2 times, most recently from cb4bcf2 to 45284da Compare December 2, 2020 03:53
@profnandaa
Copy link
Member

@ezkemboi ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The regular expression to detect phone numbers for es-CO must be changed
2 participants