Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added individualScoreResults function in isStrongPassword and updated… #2033

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ajinkyac03
Copy link

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.77%. Comparing base (86a07ba) to head (60e10b7).
Report is 122 commits behind head on master.

Files Patch % Lines
src/lib/isStrongPassword.js 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2033      +/-   ##
===========================================
- Coverage   100.00%   99.77%   -0.23%     
===========================================
  Files          104      104              
  Lines         2203     2208       +5     
  Branches       477      478       +1     
===========================================
  Hits          2203     2203              
- Misses           0        4       +4     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Brage Sekse Aarset <brage.aarset@gmail.com>
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for returnIndividualScores

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[imporve] isStrongPassword
3 participants