Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isTaxID): Adds PAN (en-IN) support to isTaxID #2182

Closed
wants to merge 3 commits into from

Conversation

Aman9723
Copy link

This commit introduces Indian TIN (PAN) support to isTaxID(..) method.

Reference

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ff0de2f) compared to base (43803c0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2182   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2348      2348           
  Branches       593       593           
=========================================
  Hits          2348      2348           
Impacted Files Coverage Δ
src/lib/isTaxID.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Updated according to the official sources.
Test case update according to the latest regex.
@Santhosh-Kumar-99
Copy link

Hi @Aman9723
There is a PR open already for PAN and GSTIN -> #2153

@Aman9723
Copy link
Author

@Santhosh-Kumar-99 thanks for letting me know.
I am new to open-source. So, should I be checking the previous PRs before working on a new feature? And should I close this pull request?

@Santhosh-Kumar-99
Copy link

@Aman9723 welcome to the community !
Yes please make sure to check for existing open PRs and their status, before working on new feature.

You can close this PR. 👍

@Aman9723 Aman9723 closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants