Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isLicensePlate): added License Plate Regex for en-SG #2333

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

Sabarinathan07
Copy link
Contributor

Added validation for Singapore license plates.

The below are some valid Singapore license plates. Singapore license plates follow a format of three letters, four numbers, and a letter.
SGX 1234 A
SMD1234Z

Refrences:
Wikipedia/Vehicle_registration_plates_of_Singapore

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (83d6ffd) to head (b0e8113).
Report is 18 commits behind head on master.

Current head b0e8113 differs from pull request most recent head 7ba516f

Please upload reports for the commit 7ba516f to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2333      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files          108      107       -1     
  Lines         2482     2450      -32     
  Branches       627      619       -8     
===========================================
- Hits          2482     2449      -33     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rubiin
rubiin previously approved these changes May 12, 2024
rubiin
rubiin previously approved these changes Jun 1, 2024
test/validators.test.js Outdated Show resolved Hide resolved
@profnandaa profnandaa merged commit 72c4674 into validatorjs:master Aug 15, 2024
10 checks passed
@profnandaa
Copy link
Member

thanks for your contrib! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants