Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isISO8601): Add support for years with more than 4 digits #2422

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(isISO8601): Add support for years with more than 4 digits #2422

wants to merge 1 commit into from

Conversation

RobinvanderVliet
Copy link
Contributor

Add support to isISO8601 for years with more than 4 digits. Fixes #2262.

Reference: https://en.wikipedia.org/wiki/ISO_8601#Years

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@pano9000
Copy link
Contributor

Hi,

thanks for the PR - however I noticed that there are no test cases for this new feature.
Could you kindly add tests as well - without test cases, this cannot be accepted.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isISO8601 doesn't support year with more than 4 digits
2 participants
@RobinvanderVliet @pano9000