Failing dates #446
Closed
Failing dates #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. What's your timezone offset? |
|
-60 |
|
Thanks. Would you mind running the test suite from the #447 branch to see if the issue is still present? |
|
The Travis containers have their system timezone set to UTC and unfortunately there's no way (AFAIK) of emulating an alternate timezone in JavaScript. |
|
Can you try #447 again? |
|
@chriso still failing |
|
This should be fixed in version |
|
@chriso you're welcome. All tests pass now. Thx for fixing it so fast :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got random failures in our tests that seem to be valid dates to me but they get denied anyway.
While testing that with validator 4.2 another date test was failing too.