Adding UA (Ukraine) postal code validation #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriso can you take a look, please? |
|
Thanks for your PR @Maxim-Mazurok, I'll review soon. |
|
@profnandaa thank you, it would be great! |
profnandaa
approved these changes
Dec 19, 2018
There was a problem hiding this comment.
LGTM, check out this - https://en.wikipedia.org/wiki/Postal_codes_in_Ukraine
profnandaa
added
the
ready-to-land
|
Thanks, @profnandaa, I linked this wiki page in original description of PR and I'm from Ukraine originally, so I can confirm that it's valid check. |
|
Thanks for the PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UA (Ukraine) postal code validation to resolve #946 issue.
Updated tests, browser build, and readme.
Rule added in according with information of Ukrainian postal codes