Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an additional regex to cater +6010 prefix for MY numbers #950

Merged
merged 3 commits into from
Dec 23, 2018
Merged

Added an additional regex to cater +6010 prefix for MY numbers #950

merged 3 commits into from
Dec 23, 2018

Conversation

idrisakmal
Copy link
Contributor

@idrisakmal idrisakmal commented Dec 14, 2018 •
edited
Loading

The original regex for ms-MY locale doesn't support for numbers starting with +6010, 010 prefix.

By adding a 0 to the regex, we can now allow for prefix 010 to be validated as Malaysian mobile phone number.

Test spec is added to validate the regex.

profnandaa
profnandaa approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa profnandaa added the ready-to-land For PRs that are reviewed and ready to be landed label Dec 19, 2018
@chriso chriso merged commit 556f54f into validatorjs:master Dec 23, 2018
@idrisakmal
Copy link
Contributor Author

Thanks @chriso and @profnandaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees

@chriso chriso

Labels
ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idrisakmal @profnandaa @chriso