Skip to content

Commit

Permalink
chore: remove obsolete yarn resolutions (#5917)
Browse files Browse the repository at this point in the history
### Description

Most of our yarn resolutions were inherited from the celo monorepo.
Where they were incrementally added to fix security issues or
unnecessary duplicated packages.

However it can cause subtle issues, when the major version doesn't match
what packages actually want, so they should be kept to a minimum.
Also some were keeping us with older versions of some packages.

So I only kept a few:
- `redux`: we only want one version
- `set-value`: fixes the following warning: `warning patch-package >
find-yarn-workspace-root > micromatch > snapdragon > base > cache-base >
union-value > set-value@0.4.3: Critical bug fixed in v3.0.1, please
upgrade to the latest version.`

### Test plan

- Tests pass

### Related issues

- Part of RET-1192

### Backwards compatibility

Yes

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [x] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)

---------

Co-authored-by: Joe Bergeron <jbergero@alum.mit.edu>
Co-authored-by: Joseph Bergeron <jophish126@gmail.com>
  • Loading branch information
3 people authored Sep 5, 2024
1 parent c2a6eb8 commit 92326d0
Show file tree
Hide file tree
Showing 2 changed files with 267 additions and 322 deletions.
37 changes: 1 addition & 36 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -284,43 +284,8 @@
"yargs": "^17.7.2"
},
"resolutions": {
"lodash": "~4.17.21",
"bignumber.js": "^9.1.2",
"prettier": "3.3.3",
"@types/prettier": "^3.0.0",
"eslint-utils": "^3.0.0",
"set-value": "^4.1.0",
"mixin-deep": "^2.0.1",
"js-yaml": "^4.1.0",
"logkitty": "^0.7.1",
"minimist": "^1.2.8",
"websocket-extensions": "^0.1.4",
"elliptic": "^6.5.7",
"dot-prop": "^8.0.2",
"bl": "^6.0.14",
"node-forge": "^1.3.1",
"underscore": "^1.13.7",
"y18n": "5.0.8",
"normalize-url": "6.1.0",
"glob-parent": "^6.0.2",
"node-fetch": "^2.7.0",
"simple-get": "^4.0.1",
"plist": "^3.1.0",
"simple-plist": "^1.3.1",
"moment": "^2.30.1",
"async": "^3.2.6",
"json-schema": "^0.4.0",
"shell-quote": "^1.8.1",
"hermes-engine": "^0.11.0",
"minimatch": "^3.1.2",
"events": "^3.3.0",
"qs": "^6.13.0",
"flat": "^5.0.2",
"crypto-js": "^4.2.0",
"browserify-sign": "^4.2.3",
"follow-redirects": "^1.15.6",
"redux": "^5.0.1",
"braces": "^3.0.3"
"set-value": "^4.1.0"
},
"detox": {
"testRunner": {
Expand Down
Loading

0 comments on commit 92326d0

Please sign in to comment.