Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove branding folder #5813

Merged
merged 8 commits into from
Aug 22, 2024
Merged

refactor: remove branding folder #5813

merged 8 commits into from
Aug 22, 2024

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Aug 21, 2024

Description

This PR:

  1. remove branding folder and move all assets to the intended android, ios, src directories
  2. in the images folder, put all .png files in an assets sub folder. these images continue to be exported from Images.ts.
  3. move "branded" components from icons to images - these are all files that use custom colours, but eventually should be all icons that are not generic (e.g. Material UI icons)
  4. remove branding script and references to it

Test plan

n/a

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@kathaypacific kathaypacific marked this pull request as ready for review August 22, 2024 10:52
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (dcbd86e) to head (159d88a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5813      +/-   ##
==========================================
- Coverage   87.28%   87.28%   -0.01%     
==========================================
  Files         737      737              
  Lines       31183    31178       -5     
  Branches     5222     5222              
==========================================
- Hits        27218    27213       -5     
  Misses       3920     3920              
  Partials       45       45              
Files Coverage Δ
src/backup/BackupIntroduction.tsx 90.00% <100.00%> (ø)
src/brandingConfig.ts 100.00% <ø> (ø)
src/components/BeatingHeartLoader.tsx 92.30% <100.00%> (ø)
src/dappsExplorer/DappCard.tsx 100.00% <100.00%> (ø)
src/earn/EarnDepositBottomSheet.tsx 98.59% <100.00%> (ø)
src/earn/EarnInfoScreen.tsx 98.03% <100.00%> (ø)
src/home/NotificationBox.tsx 88.65% <100.00%> (ø)
src/images/Blob.tsx 100.00% <ø> (ø)
src/images/GuideKeyHomeCardIcon.tsx 100.00% <ø> (ø)
src/images/GuideKeyIcon.tsx 100.00% <ø> (ø)
... and 50 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbd86e...159d88a. Read the comment docs.

Copy link
Contributor

@bakoushin bakoushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kathaypacific kathaypacific added this pull request to the merge queue Aug 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2024
@bakoushin bakoushin added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 7700030 Aug 22, 2024
16 checks passed
@bakoushin bakoushin deleted the kathy/branding-2 branch August 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants