-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove branding folder #5813
Conversation
9db757d
to
5847420
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5813 +/- ##
==========================================
- Coverage 87.28% 87.28% -0.01%
==========================================
Files 737 737
Lines 31183 31178 -5
Branches 5222 5222
==========================================
- Hits 27218 27213 -5
Misses 3920 3920
Partials 45 45
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Description
This PR:
android
,ios
,src
directoriesimages
folder, put all.png
files in anassets
sub folder. these images continue to be exported fromImages.ts
.icons
toimages
- these are all files that use custom colours, but eventually should be all icons that are not generic (e.g. Material UI icons)Test plan
n/a
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: