Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use 2 letter code for hooks API language header #5846

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented Aug 27, 2024

Description

hooks repo .crowdin.yml (here) uses 2 letter code for language, update API header to use that. Same as dapp-list.

Test plan

Unit tests updated

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.31%. Comparing base (30e9d0f) to head (47ebb1f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5846      +/-   ##
==========================================
+ Coverage   87.30%   87.31%   +0.01%     
==========================================
  Files         731      731              
  Lines       31266    31267       +1     
  Branches     5546     5543       -3     
==========================================
+ Hits        27296    27300       +4     
+ Misses       3746     3743       -3     
  Partials      224      224              
Files Coverage Δ
src/positions/saga.ts 90.81% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e9d0f...47ebb1f. Read the comment docs.

@finnian0826 finnian0826 added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 5df79c9 Aug 27, 2024
17 checks passed
@finnian0826 finnian0826 deleted the finnian0826/fix-language-for-hooks branch August 27, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants