Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(earn): update deposit bottom sheet design #6016

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

@satish-ravi satish-ravi commented Sep 17, 2024

Description

Updates for the deposit mode, swap + deposit will be in a follow up. Changes include

  • Removing logo
  • Including both fiat and crypto values for deposit amount and fees
  • copy updates
  • minor style updates

Figma

Test plan

Unit tests, manual

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (d4067d4) to head (297ee85).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6016      +/-   ##
==========================================
- Coverage   88.62%   88.61%   -0.02%     
==========================================
  Files         726      725       -1     
  Lines       30516    30485      -31     
  Branches     5532     5532              
==========================================
- Hits        27044    27013      -31     
  Misses       3272     3272              
  Partials      200      200              
Files with missing lines Coverage Δ
src/earn/EarnDepositBottomSheet.tsx 98.41% <100.00%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4067d4...297ee85. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit e6743eb Sep 17, 2024
15 checks passed
@satish-ravi satish-ravi deleted the satish/act-1358-1 branch September 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants