chore: add app name to support requests #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6029 +/- ##
==========================================
+ Coverage 88.61% 88.70% +0.09%
==========================================
Files 725 727 +2
Lines 30488 30769 +281
Branches 5231 5305 +74
==========================================
+ Hits 27017 27295 +278
- Misses 3428 3431 +3
Partials 43 43
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jeanregisser
approved these changes
Sep 18, 2024
src/account/zendesk.ts
Outdated
| await _createRequest({ | ||
| message: `${message} | ||
|
|
||
| ${JSON.stringify(deviceInfo)} | ||
| ${JSON.stringify(userProperties)} |
There was a problem hiding this comment.
Wondering if we should indent it, so the support team can more easily read it?
Suggested change
| ${JSON.stringify(userProperties)} | |
| ${JSON.stringify(userProperties, null, 2)} |
src/account/zendesk.test.ts
Outdated
| @@ -48,7 +53,7 @@ describe('Zendesk', () => { | |||
| sessionId: '1234', | |||
| numberVerifiedCentralized: true, | |||
| network: 'mainnet', | |||
| } as DeviceInfo, | |||
| } as SupportRequestUserProperties, | |||
There was a problem hiding this comment.
nit: unrelated to the changes here, but I'm wondering if we could remove the cast. Maybe using as const or sastifies SupportRequestUserProperties
kathaypacific
added a commit
to mobilestack-xyz/mobilestack-shefi
that referenced
this pull request
Sep 20, 2024
### Description [Context](https://valora-app.slack.com/archives/C07KBTP7RC2/p1726606329650329) - the ask is to add the app name in the support request body and also add it as a zendesk property so that it can be tracked more easily. ### Test plan n/a ### Related issues n/a ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
MuckT
pushed a commit
that referenced
this pull request
Sep 21, 2024
### Description [Context](https://valora-app.slack.com/archives/C07KBTP7RC2/p1726606329650329) - the ask is to add the app name in the support request body and also add it as a zendesk property so that it can be tracked more easily. ### Test plan n/a ### Related issues n/a ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
jeanregisser
pushed a commit
to mobilestack-xyz/mobilestack-shefi
that referenced
this pull request
Sep 26, 2024
### Description [Context](https://valora-app.slack.com/archives/C07KBTP7RC2/p1726606329650329) - the ask is to add the app name in the support request body and also add it as a zendesk property so that it can be tracked more easily. ### Test plan n/a ### Related issues n/a ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context - the ask is to add the app name in the support request body and also add it as a zendesk property so that it can be tracked more easily.
Test plan
n/a
Related issues
n/a
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: