Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ramp): update mock data to use Ramp Network name #6098

Closed
wants to merge 4 commits into from

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Sep 26, 2024

Description

Small PR to update Ramp mock data and check that no other updates are needed on the wallet side.

Test plan

  • Unit tests updated.

Related issues

valora-inc/address-metadata#570
https://github.com/valora-inc/cloud-functions/pull/448

Part of ACT-1396

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (312d7e0) to head (a5d8fce).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6098      +/-   ##
==========================================
- Coverage   88.74%   88.74%   -0.01%     
==========================================
  Files         727      727              
  Lines       30785    30785              
  Branches     5623     5623              
==========================================
- Hits        27321    27320       -1     
- Misses       3265     3266       +1     
  Partials      199      199              
Files with missing lines Coverage Δ
test/values.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312d7e0...a5d8fce. Read the comment docs.

@MuckT MuckT closed this Sep 30, 2024
@MuckT MuckT deleted the tomm/act-1396 branch September 30, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant