Skip to content

Commit

Permalink
test: remove //nolint:govet comments (#1729)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandear committed Mar 2, 2024
1 parent 3166afd commit bdd459a
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions args_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,8 @@ func testCopyTo(t *testing.T, a *Args) {
var b Args
a.CopyTo(&b)

if !reflect.DeepEqual(*a, b) { //nolint:govet
t.Fatalf("ArgsCopyTo fail, a: \n%+v\nb: \n%+v\n", *a, b) //nolint:govet
if !reflect.DeepEqual(a, &b) {
t.Fatalf("ArgsCopyTo fail, a: \n%+v\nb: \n%+v\n", a, &b)
}

b.VisitAll(func(k, _ []byte) {
Expand Down
12 changes: 6 additions & 6 deletions header_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1407,8 +1407,8 @@ func TestResponseHeaderCopyTo(t *testing.T) {
h.bufKV = argsKV{}
h1.bufKV = argsKV{}

if !reflect.DeepEqual(h, h1) { //nolint:govet
t.Fatalf("ResponseHeaderCopyTo fail, src: \n%+v\ndst: \n%+v\n", h, h1) //nolint:govet
if !reflect.DeepEqual(&h, &h1) {
t.Fatalf("ResponseHeaderCopyTo fail, src: \n%+v\ndst: \n%+v\n", &h, &h1)
}
}

Expand Down Expand Up @@ -1450,8 +1450,8 @@ func TestRequestHeaderCopyTo(t *testing.T) {
h.bufKV = argsKV{}
h1.bufKV = argsKV{}

if !reflect.DeepEqual(h, h1) { //nolint:govet
t.Fatalf("RequestHeaderCopyTo fail, src: \n%+v\ndst: \n%+v\n", h, h1) //nolint:govet
if !reflect.DeepEqual(&h, &h1) {
t.Fatalf("RequestHeaderCopyTo fail, src: \n%+v\ndst: \n%+v\n", &h, &h1)
}
}

Expand All @@ -1466,7 +1466,7 @@ func TestResponseContentTypeNoDefaultNotEmpty(t *testing.T) {
headers := h.String()

if strings.Contains(headers, "Content-Type: \r\n") {
t.Fatalf("ResponseContentTypeNoDefaultNotEmpty fail, response: \n%+v\noutcome: \n%q\n", h, headers) //nolint:govet
t.Fatalf("ResponseContentTypeNoDefaultNotEmpty fail, response: \n%+v\noutcome: \n%q\n", &h, headers)
}
}

Expand Down Expand Up @@ -1534,7 +1534,7 @@ func TestResponseDateNoDefaultNotEmpty(t *testing.T) {
headers := h.String()

if strings.Contains(headers, "\r\nDate: ") {
t.Fatalf("ResponseDateNoDefaultNotEmpty fail, response: \n%+v\noutcome: \n%q\n", h, headers) //nolint:govet
t.Fatalf("ResponseDateNoDefaultNotEmpty fail, response: \n%+v\noutcome: \n%q\n", &h, headers)
}
}

Expand Down
8 changes: 4 additions & 4 deletions http_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,17 +155,17 @@ func testRequestCopyTo(t *testing.T, src *Request) {
var dst Request
src.CopyTo(&dst)

if !reflect.DeepEqual(*src, dst) { //nolint:govet
t.Fatalf("RequestCopyTo fail, src: \n%+v\ndst: \n%+v\n", *src, dst) //nolint:govet
if !reflect.DeepEqual(src, &dst) {
t.Fatalf("RequestCopyTo fail, src: \n%+v\ndst: \n%+v\n", src, &dst)
}
}

func testResponseCopyTo(t *testing.T, src *Response) {
var dst Response
src.CopyTo(&dst)

if !reflect.DeepEqual(*src, dst) { //nolint:govet
t.Fatalf("ResponseCopyTo fail, src: \n%+v\ndst: \n%+v\n", *src, dst) //nolint:govet
if !reflect.DeepEqual(src, &dst) {
t.Fatalf("ResponseCopyTo fail, src: \n%+v\ndst: \n%+v\n", src, &dst)
}
}

Expand Down
8 changes: 4 additions & 4 deletions uri_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,14 @@ func TestURICopyTo(t *testing.T) {
var u URI
var copyU URI
u.CopyTo(&copyU)
if !reflect.DeepEqual(u, copyU) { //nolint:govet
t.Fatalf("URICopyTo fail, u: \n%+v\ncopyu: \n%+v\n", u, copyU) //nolint:govet
if !reflect.DeepEqual(&u, &copyU) {
t.Fatalf("URICopyTo fail, u: \n%+v\ncopyu: \n%+v\n", &u, &copyU)
}

u.UpdateBytes([]byte("https://example.com/foo?bar=baz&baraz#qqqq"))
u.CopyTo(&copyU)
if !reflect.DeepEqual(u, copyU) { //nolint:govet
t.Fatalf("URICopyTo fail, u: \n%+v\ncopyu: \n%+v\n", u, copyU) //nolint:govet
if !reflect.DeepEqual(&u, &copyU) {
t.Fatalf("URICopyTo fail, u: \n%+v\ncopyu: \n%+v\n", &u, &copyU)
}
}

Expand Down

0 comments on commit bdd459a

Please sign in to comment.