Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP: chore(xo-server/redis): serialize with JSON #3209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julien-f
Copy link
Member

@julien-f julien-f commented Jul 19, 2018

Serialize all data with JSON at the collection level.

  • simplify code
  • supports all types without needing special handling

To merge just after a release to have a full cycle to test!

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • CHANGELOG:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer
  4. if necessary, update your PR, and re- add a reviewer

julien-f added a commit that referenced this pull request Jul 19, 2018
This reverts commit d51527b.

Causing too much issues, a new approach is developed in #3209.
@julien-f
Copy link
Member Author

This should be tested thoroughly before being merged.

Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an issue here:

try {
pluginMetadata.configuration =
configuration && JSON.parse(configuration)
} catch (error) {
console.warn(
'cannot parse pluginMetadata.configuration:',
configuration
)
pluginMetadata.configuration = []
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Xen Orchestra
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants