Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup-reports): mjml template #7747

Merged
merged 10 commits into from
Jun 27, 2024
Merged

feat(backup-reports): mjml template #7747

merged 10 commits into from
Jun 27, 2024

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented Jun 13, 2024

Description

Backup reports using MJML.

image

image
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@b-Nollet b-Nollet requested a review from julien-f June 13, 2024 08:18
@b-Nollet b-Nollet force-pushed the mjml-backup-reports branch 3 times, most recently from 1906642 to 818b899 Compare June 18, 2024 08:26
@julien-f julien-f removed their request for review June 19, 2024 09:28
@b-Nollet b-Nollet requested a review from julien-f June 20, 2024 13:14
@b-Nollet b-Nollet requested a review from julien-f June 25, 2024 08:44
@b-Nollet b-Nollet marked this pull request as ready for review June 25, 2024 14:49
Comment on lines 10 to 11
import markdownTransform from '../templates/markdown/transform.js'
import mjmlTransform from '../templates/mjml/transform.js'
Copy link
Member

@julien-f julien-f Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low priority

Import them "dynamically":

const templates = new Map()
for (const name of ['markdown', 'mjml']) {
  // todo
}

@b-Nollet b-Nollet requested a review from julien-f June 26, 2024 15:25
@julien-f julien-f changed the title feat(backups-reports): mjml backup reports feat(backup-reports): mjml template Jun 27, 2024
@julien-f julien-f merged commit f5cee45 into master Jun 27, 2024
1 check passed
@julien-f julien-f deleted the mjml-backup-reports branch June 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants