Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node.js github action ci/cd check #3060

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Add node.js github action ci/cd check #3060

merged 1 commit into from
Sep 21, 2023

Conversation

Jzow
Copy link

@Jzow Jzow commented Sep 21, 2023

CC: #3059

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jzow
Copy link
Author

Jzow commented Sep 21, 2023

@jinmao88 It is necessary to conduct node check, which will eliminate some PR error

@jinmao88
Copy link
Collaborator

这个具体有啥用

@Jzow
Copy link
Author

Jzow commented Sep 21, 2023

这个具体有啥用

检测每次PR和修改代码的编译情况,如果出现X那就不应该进行代码合并,反之可以合并,可以理解为检查编译代码的验证

@jinmao88 jinmao88 merged commit b7554fd into vbenjs:main Sep 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants