Added automatic generation of select options for stickit bindings. #69
Conversation
| * @method _generateSelectOptions | ||
| * @param element {Element} The select element to generate options for | ||
| * @param opts {Object} Additional behavior options for the bindings | ||
| * @param [options.modelFormat] {Object} The function called before setting model values |
| options = $(element).children('option'); | ||
|
|
||
| _.each(options, function(option) { | ||
| collection.push({'label': $(option).text(), |
There was a problem hiding this comment.
last question. This all looks good, but I'm a little worried about blowing away your select options if they have different classes/attributes that you had added before. Will you lose classes?
There was a problem hiding this comment.
I just tested this- you will lose classes on the select options. You won't lose data on the actual select though. There might be a clever way to get around this with the 'classes' bindings available in stickit - I will think about it some more.
There was a problem hiding this comment.
There doesn't seem to be a way to keep your classes while binding select options using selectOptions - any ideas?
There was a problem hiding this comment.
@ccpowers, I think you should merge this. Though, let's create an enhancement to keep classes on two-way bound select options.
There was a problem hiding this comment.
@ccpowers, do you want to keep working on this or should I take over?
There was a problem hiding this comment.
@kentmw I'm happy to finish it but i'm about to leave the country for a month so if you want it done before October, you should probably take over...just let me know
There was a problem hiding this comment.
We can wait until you get back, that will be fine. If we need it before you return, we'll create a new PR. Have fun!
There was a problem hiding this comment.
Hey @ccpowers, are you back? Any interest in picking this back up? We're pretty close to finishing.
Conflicts: modules/FormView.js
No description provided.