Drop support for emacs < 26 #26
Comments
|
This is planned for the v1.0.0 |
vedang
added
the
cleanup
|
Updating the title to reflect that we will now also drop support for Emacs 25. |
vedang
added a commit
that referenced
this issue
Apr 26, 2022
With the release of Emacs 28, we are dropping support for Emacs 24 and 25 (`pdf-tools` is adopting the policy to support on the latest 3 Emacs major versions). This commit simply changes the README file, no actual change in the code has been made yet. I'll make the code changes as part of work towards the 1.0.0 release milestone. Relates to: #26
vedang
added a commit
that referenced
this issue
Oct 3, 2022
Fix warnings and remove code for supporting older versions of Emacs from the following files: 1. `pdf-annot.el` Relates to: #26
vedang
added a commit
that referenced
this issue
Oct 3, 2022
* lisp/pdf-annot.el (pdf-annot-run-modified-hooks): Use cl-case instead of cl-ecase, as the latter does not support t/otherwise clauses. Remove nil clause which never matches. See https://bugs.gnu.org/51368. (pdf-annot-edit-contents-finalize): * lisp/pdf-sync.el (pdf-sync-minor-mode): Mark up symbols `like-this', to avoid having the apostrophe interpreted as a closing single quote. Remove redundant backslashes. (pdf-sync-synctex-file-name): Use line-beginning-position in place of point-at-bol, which is deprecated in Emacs 29. * lisp/pdf-util.el: Autoload list-colors-duplicates before its use in pdf-util-color-completions, as facemenu is not preloaded since Emacs 28. (pdf-util-hexcolor): Use ash in place of lsh, which is deprecated in Emacs 29. (pdf-util-convert): Fix docstring markup and indentation. * lisp/pdf-virtual.el (pdf-virtual-define-adapter): Refill generated docstring to avoid exceeding 80 column warning threshold. Relates to: #26 Relates to: #80 Closes: #150
vedang
added a commit
that referenced
this issue
Oct 13, 2022
This is dead-code for supporting Emacs <26.3 Relates to: #26
vedang
added a commit
that referenced
this issue
Oct 13, 2022
This is no longer necessary, since we are dropping support for Emacs 24.3 Relates to: #26
vedang
added a commit
that referenced
this issue
Oct 13, 2022
Rely on the functions that come built into Emacs. Relates to: #26
vedang
added a commit
that referenced
this issue
Oct 13, 2022
`window-body-width` is available for us to use in Emacs 26.3 Relates to: #26
vedang
added a commit
that referenced
this issue
Oct 13, 2022
vedang
added a commit
that referenced
this issue
Oct 13, 2022
All the code working around issues in Emacs 24 and Emacs 25 has been removed at this point! (or at least, as much of it as I could find) I've tested against Emacs 28 and it's working fine. I need many more automated tests to ensure that behaviour does not break across multiple Emacs versions / operating systems, but that is a topic for another day. Closes: #26
Closed
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
This is dead-code for supporting Emacs <26.3 Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
This is no longer necessary, since we are dropping support for Emacs 24.3 Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
Rely on the functions that come built into Emacs. Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
`window-body-width` is available for us to use in Emacs 26.3 Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
All the code working around issues in Emacs 24 and Emacs 25 has been removed at this point! (or at least, as much of it as I could find) I've tested against Emacs 28 and it's working fine. I need many more automated tests to ensure that behaviour does not break across multiple Emacs versions / operating systems, but that is a topic for another day. This commit bumps the version of `pdf-tools` from `1.0.0snapshot` to `1.0.0`. I do not expect this to have any real change either on Melpa Stable or Non-GNU Elpa, since they already parse the version as 1.0.0. I am not creating a tag at the moment. I will do some more cleanup work and directly create a `1.1.0` post those changes. Closes: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
This is dead-code for supporting Emacs <26.3 Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
This is no longer necessary, since we are dropping support for Emacs 24.3 Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
Rely on the functions that come built into Emacs. Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
`window-body-width` is available for us to use in Emacs 26.3 Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
Relates to: vedang#26
aikrahguzar
pushed a commit
to aikrahguzar/pdf-tools
that referenced
this issue
Apr 25, 2023
All the code working around issues in Emacs 24 and Emacs 25 has been removed at this point! (or at least, as much of it as I could find) I've tested against Emacs 28 and it's working fine. I need many more automated tests to ensure that behaviour does not break across multiple Emacs versions / operating systems, but that is a topic for another day. This commit bumps the version of `pdf-tools` from `1.0.0snapshot` to `1.0.0`. I do not expect this to have any real change either on Melpa Stable or Non-GNU Elpa, since they already parse the version as 1.0.0. I am not creating a tag at the moment. I will do some more cleanup work and directly create a `1.1.0` post those changes. Closes: vedang#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AFAICS emacs < 25 is not part of the continuous integration setup (the minimal emacs version tested in circleci is emacs-25; In the appveyor setup I can't find the versions of emacs that are tested: This seems to be the cmd used for installing emacs in appveyor:
bash -lc "pacman -S --needed --noconfirm mingw-w64-x86_64-emacs")Dropping support for emacs < 25 would allow us to remove compatiblity code e.g. in pdf-view.el, which currently leads to a byte-compiler-warning (see #24).
The text was updated successfully, but these errors were encountered: