Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support converting a Chart to a Vega editor URL #3252

Merged
merged 9 commits into from
Nov 6, 2023
Merged

Support converting a Chart to a Vega editor URL #3252

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
962e593
Add to_url method to convert chart to Vega editor URL
jonmmease Sep 30, 2023
7ece883
Add to_url documentation
jonmmease Nov 5, 2023
f85d682
Add changelog
jonmmease Nov 5, 2023
1965024
Move to local import
jonmmease Nov 5, 2023
a49cc43
ruff format
jonmmease Nov 5, 2023
6183625
update url test
jonmmease Nov 5, 2023
043b369
typing
jonmmease Nov 5, 2023
454fd67
reword
jonmmease Nov 5, 2023
5d440f9
make fullscreen a keyword-only argument
jonmmease Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move to local import
  • Loading branch information
@jonmmease
jonmmease committed Nov 5, 2023
commit 1965024feb81995842f105312db6787feb2b42f5
2 changes: 1 addition & 1 deletion altair/vegalite/v5/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from .display import renderers, VEGALITE_VERSION, VEGAEMBED_VERSION, VEGA_VERSION
from .theme import themes
from .compiler import vegalite_compilers
from ...utils._importers import import_vl_convert
from ...utils._vegafusion_data import (
using_vegafusion as _using_vegafusion,
compile_with_vegafusion as _compile_with_vegafusion,
Expand Down Expand Up @@ -1069,6 +1068,7 @@ def to_url(self, fullscreen: bool = False):
fullscreen : bool
If True, editor will open chart in fullscreen mode. Default False
"""
from ...utils._importers import import_vl_convert
vlc = import_vl_convert()
if _using_vegafusion():
return vlc.vega_to_url(self.to_dict(format="vega"), fullscreen=fullscreen)
Expand Down
Loading