Add build tag support #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamccall
approved these changes
Apr 11, 2017
There was a problem hiding this comment.
Ran all tests on my Ubuntu box everything looks good to me
build-results.txt
| @@ -0,0 +1,24 @@ | |||
| package mockery | |||
There was a problem hiding this comment.
I was thinking about doing this the other day 👍
|
Any chance this could be merged? I'd love to make use of this :) |
LandonTClipp
pushed a commit
to LandonTClipp/mockery
that referenced
this pull request
Oct 19, 2023
When the type and the package name is the same for an anonymous parameter (ex: time.Time), and there are more than 1 such parameters, the generated name for both was the same. And the generated code would not be valid. Fix the bug by ensuring the parameter name does not conflict with package imports first before checking against other parameter names.
LandonTClipp
pushed a commit
to LandonTClipp/mockery
that referenced
this pull request
Nov 20, 2023
When the type and the package name is the same for an anonymous parameter (ex: time.Time), and there are more than 1 such parameters, the generated name for both was the same. And the generated code would not be valid. Fix the bug by ensuring the parameter name does not conflict with package imports first before checking against other parameter names.
LandonTClipp
pushed a commit
to LandonTClipp/mockery
that referenced
this pull request
Dec 23, 2023
When the type and the package name is the same for an anonymous parameter (ex: time.Time), and there are more than 1 such parameters, the generated name for both was the same. And the generated code would not be valid. Fix the bug by ensuring the parameter name does not conflict with package imports first before checking against other parameter names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #109 by reusing go/build.Context.MatchFile to know if we should include a given file.
(tests results on Windows)