Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Change max height to min height for channel assignment block #2984

Conversation

monrostar
Copy link
Contributor

@monrostar monrostar commented Jul 31, 2024

Description

Updated the block height for the Channel block .channel-assignment. Because there was a fixed height there, a large number of channels simply did not fit and the button to add new channels was hidden

Breaking changes

Does this PR include any breaking changes we should be aware of?

  • no

Screenshots

Before
image
After
image

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jul 31, 2024 0:44am

@monrostar
Copy link
Contributor Author

@michaelbromley

I don't know why this fix hasn't been made yet, but it's so annoying :)
Even though we don't use this functionality, I would like to see all channels and the button :)

@michaelbromley
Copy link
Member

Does this still look reasonable with only eg 2 channels assigned? Not too much white space?

@monrostar
Copy link
Contributor Author

monrostar commented Jul 31, 2024

Does this still look reasonable with only eg 2 channels assigned? Not too much white space?

Yeah, that's a good question :) I'll update again

@monrostar
Copy link
Contributor Author

Does this still look reasonable with only eg 2 channels assigned? Not too much white space?

Yeah, that's a good question :) I'll update again

24px will be fine. This is almost minimum

image

@michaelbromley michaelbromley merged commit 0f8bdb5 into vendure-ecommerce:master Jul 31, 2024
13 of 14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
@michaelbromley
Copy link
Member

Thanks!

@monrostar monrostar deleted the feat/change-max-height-to-min-height-for-channel-assignment-ui-block branch July 31, 2024 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants