Improve EDK2 build process script for simplicity and reliability #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update script to remove the existing EDK2 directory and unzip the new one, ensuring a clean start for the build process. - Add a check to exit the script if changing to the EDK2 directory fails, enhancing the robustness of the script. - Introduce a function `build_edk2` to streamline the building of EDK2 for different architectures (i386-efi, arm64-efi, and x86_64-efi). This function takes the architecture as an argument and executes the corresponding build command. - Replace repetitive build commands with calls to `build_edk2` function, reducing redundancy and improving the readability of the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_edk2to streamline the building of EDK2 for different architectures (i386-efi, arm64-efi, and x86_64-efi). This function takes the architecture as an argument and executes the corresponding build command.build_edk2function, reducing redundancy and improving the readability of the script.Note:
I did not test this refactored code. Merge only after testing.