Refactor vtoycli compilation script for enhanced clarity and modularity #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce a `compile_vtoycli` function to centralize the compilation logic for different architectures. This function accepts the compiler, library, output binary name, and extra flags as arguments. - Simplify removal of old binaries by consolidating `rm` commands into a single line. - Utilize the `compile_vtoycli` function to compile the `vtoycli` tool for x64, ia32, aarch64, and mips64el architectures. - Improve the check for successful compilation by verifying the existence of all expected binaries before proceeding to strip and move them. - Streamline the stripping and moving of binaries to their respective directories, enhancing the script's readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compile_vtoyclifunction to centralize the compilation logic for different architectures. This function accepts the compiler, library, output binary name, and extra flags as arguments.rmcommands into a single line.compile_vtoyclifunction to compile thevtoyclitool for x64, ia32, aarch64, and mips64el architectures.Note:
I did not test this refactored code. Merge only after testing.