Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

chore: Upgrade Preact #544

Merged
merged 3 commits into from
Oct 20, 2019
Merged

chore: Upgrade Preact #544

merged 3 commits into from
Oct 20, 2019

Conversation

9renpoto
Copy link
Contributor

@9renpoto 9renpoto commented Oct 3, 2019

@9renpoto 9renpoto changed the title chore: Upgrade preact chore: Upgrade Preact Oct 3, 2019
Copy link

@alecrae alecrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the README installation instructions be updated to npm install --save @zeit/next-preact preact as the preact-compat and preact-context are not used anymore? I can do a PR to your branch if you'd like

@jwarkentin
Copy link

Since the changes are approved, can someone merge this? I'm trying to get started with the latest version of Preact right now and this would make that easier.

@lazidoca
Copy link

I have set up a very similar to this pull request to try Preact 10 with Next.js and have errors with createContext when using react-icons

A very minimal repo here:

https://github.com/lazidoca/nextjs-preactX

@stevewillard
Copy link

Any chance this could be merged?

@developit
Copy link
Contributor

Only note from me: it would probably be better to have preact-ssr-prepass as a dependency of this plugin, since it's used internally in Next.

moduleAlias.addAlias('react-dom', 'preact-compat')
moduleAlias.addAlias('react', 'preact/compat')
moduleAlias.addAlias('react-dom', 'preact/compat')
moduleAlias.addAlias('react-ssr-prepass', 'preact-ssr-prepass')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my other comment, I'd prefer preact-ssr-prepass be a dependency of this plugin rather than being left up to userland.

Suggested change
moduleAlias.addAlias('react-ssr-prepass', 'preact-ssr-prepass')
moduleAlias.addAlias('react-ssr-prepass', require.resolve('preact-ssr-prepass'))

@Timer Timer merged commit 1546ae6 into vercel:master Oct 20, 2019
@9renpoto 9renpoto deleted the feature/preact-x branch October 20, 2019 23:03
@kenk2
Copy link

kenk2 commented Oct 21, 2019

Will this be updated on NPM? I'm still getting the old version of it from the registry.

@reaktivo
Copy link

reaktivo commented Nov 20, 2019

Sorry to bump, but as @kennykimjr mentioned, the old version of this plugin is still in the registry.

@Fuzznimp
Copy link

Any news on pushing the new version to NPM ?

@marvinhagemeister
Copy link

Disclaimer: I work on Preact

We're getting reports of Preact and hooks not working with nextjs from time to time and they often use @zeit/next-preact which points to an outdated Preact version that doesn't support hooks.

We'd be really thankful if the package on npm can be updated. This would save us quite a bit of time when debugging issues related to nextjs. Please publish a new version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When is next-preact getting updated to preact X? Next-Preact Plugin Breaks with Preact X and/or Next 8.1.0