chore: drop web streams polyfilling on globalThis

vercel · Oct 19, 2023 · fcf08e8 · fcf08e8
1 parent a3aa659
commit fcf08e8
Show file tree

Hide file tree

Showing 11 changed files with 4 additions and 97 deletions.
diff --git a/packages/next/src/export/worker.ts b/packages/next/src/export/worker.ts
@@ -7,7 +7,6 @@ import type {
   WorkerRenderOpts,
 } from './types'
 
-import '../server/node-polyfill-web-streams'
 import '../server/node-environment'
 
 process.env.NEXT_IS_EXPORT_WORKER = 'true'

diff --git a/packages/next/src/server/app-render/action-handler.ts b/packages/next/src/server/app-render/action-handler.ts
@@ -40,27 +40,8 @@ import type { AppRenderContext, GenerateFlight } from './app-render'
 
 function nodeToWebReadableStream(nodeReadable: import('stream').Readable) {
   if (process.env.NEXT_RUNTIME !== 'edge') {
-    const { Readable } = require('stream')
-    if ('toWeb' in Readable && typeof Readable.toWeb === 'function') {
-      return Readable.toWeb(nodeReadable)
-    }
-
-    const iterator = nodeReadable[Symbol.asyncIterator]()
-
-    return new ReadableStream({
-      pull: async (controller) => {
-        const { value, done } = await iterator.next()
-
-        if (done) {
-          controller.close()
-        } else {
-          controller.enqueue(value)
-        }
-      },
-      cancel: () => {
-        iterator.return?.()
-      },
-    })
+    const { Readable } = require('stream') as typeof import('stream')
+    return Readable.toWeb(nodeReadable)
   } else {
     throw new Error('Invalid runtime')
   }

diff --git a/packages/next/src/server/lib/incremental-cache/index.ts b/packages/next/src/server/lib/incremental-cache/index.ts
@@ -9,8 +9,6 @@ import FileSystemCache from './file-system-cache'
 import path from '../../../shared/lib/isomorphic/path'
 import { normalizePagePath } from '../../../shared/lib/page-path/normalize-page-path'
 
-import '../../node-polyfill-web-streams'
-
 import {
   CACHE_ONE_YEAR,
   NEXT_CACHE_REVALIDATED_TAGS_HEADER,

diff --git a/packages/next/src/server/lib/router-utils/resolve-routes.ts b/packages/next/src/server/lib/router-utils/resolve-routes.ts
@@ -35,8 +35,6 @@ import {
 } from '../../../shared/lib/router/utils/prepare-destination'
 import { createRequestResponseMocks } from '../mock-request'
 
-import '../../node-polyfill-web-streams'
-
 const debug = setupDebug('next:router-server:resolve-routes')
 
 export function getResolveRoutes(

diff --git a/packages/next/src/server/next-server.ts b/packages/next/src/server/next-server.ts
@@ -1,7 +1,6 @@
 import './node-environment'
 import './require-hook'
 import './node-polyfill-form'
-import './node-polyfill-web-streams'
 import './node-polyfill-crypto'
 
 import type { TLSSocket } from 'tls'

diff --git a/packages/next/src/server/node-polyfill-web-streams.ts b/packages/next/src/server/node-polyfill-web-streams.ts
diff --git a/packages/next/src/server/pipe-readable.ts b/packages/next/src/server/pipe-readable.ts
@@ -1,7 +1,5 @@
 import type { ServerResponse } from 'node:http'
 
-import './node-polyfill-web-streams'
-
 import {
   ResponseAbortedName,
   createAbortController,

diff --git a/packages/next/src/server/render.tsx b/packages/next/src/server/render.tsx
@@ -113,8 +113,6 @@ let postProcessHTML: typeof import('./post-process').postProcessHTML
 
 const DOCTYPE = '<!DOCTYPE html>'
 
-import './node-polyfill-web-streams'
-
 if (process.env.NEXT_RUNTIME !== 'edge') {
   tryGetPreviewData =
     require('./api-utils/node/try-get-preview-data').tryGetPreviewData

diff --git a/packages/next/src/server/stream-utils/node-web-streams-helper.ts b/packages/next/src/server/stream-utils/node-web-streams-helper.ts
@@ -1,7 +1,5 @@
 import type { FlightRouterState } from '../app-render/types'
 
-import '../node-polyfill-web-streams'
-
 import { nonNullable } from '../../lib/non-nullable'
 import { getTracer } from '../lib/trace/tracer'
 import { AppRenderSpan } from '../lib/trace/constants'

diff --git a/test/__mocks__/node-polyfill-web-streams.js b/test/__mocks__/node-polyfill-web-streams.js
diff --git a/test/lib/mocks-require-hook.js b/test/lib/mocks-require-hook.js
@@ -1,11 +1,7 @@
 const mod = require('module')
 
-const hookPropertyMap = new Map([
-  [
-    /node-polyfill-web-streams/,
-    require.resolve('../__mocks__/node-polyfill-web-streams.js'),
-  ],
-])
+// REVIEW: is this necessary still?
+const hookPropertyMap = new Map([[]])
 
 function matchModule(request) {
   for (const [key, value] of hookPropertyMap) {