Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-jest #13003

Merged
merged 18 commits into from
May 18, 2020
Merged

Add eslint-plugin-jest #13003

merged 18 commits into from
May 18, 2020

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented May 17, 2020

Linting the tests folder with eslint-plugin-jest to catch some common errors early on.

    {
      "files": ["test/**/*.test.js"],
      "extends": ["plugin:jest/recommended"],
      "rules": {
        "jest/expect-expect": "off",
        "jest/no-disabled-tests": "off",
        "jest/no-try-expect": "off"
      }
    },

Problems that needed to be fixed before the plugin is enabled:

  • expect call without corresponding matcher: expect($('.abc').length === 1) will never throw, it needs to be written as expect($('.abc').length === 1).toBe(true) or better expect($('.abc')).toHaveLength(1).
  • regression after fixing ☝️ in integration/config: is build id supposed to be '-' or 'development'? Did some forensics, it's supposed to be development now.
  • regression after fixing ☝️ in integration/config: behavior of module-only package seems to be unexpected. Is the test out of date or is this a regression? Add module as server fallback main field #6256 @Timer it appears that with 'main', 'module' as mainfields, webpack always resolves to module/index.js if it exists, even if main is not specified in package.json. Probably not an easy fix but it seems like this test never worked as intended. With this assumption, I will skip it for know. It's expected behavior, the fixture was wrong, this never got caught because of the missing expectation. Fixed the fixture to make the test pass
  • duplicate describe or test titles
  • replace commented out test with skipped test
  • duplicate describe or test titles in integration/file-serving: these seem to be duplicated tests, needs investigation: ignored those for now in this file. It can be cleaned up later if necessary
  • fix 8 occurences of jest/no-try-expect or ignore: ignored those for now
  • fix 1 occurence jest/no-test-callback or ignore
  • refactored more tests inintegration/config to make them work on windows. I placed all tests in the same file to make it less cumbersome to work with. I also replaced some waitFor with polling logic, and I reenabled and fixed a test that was commented out.

@Janpot Janpot marked this pull request as draft May 17, 2020 10:43
@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 11.9s 12.1s ⚠️ +206ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.95 2.002 ⚠️ +0.05
/ avg req/sec 1281.76 1248.51 -33.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.108 1.139 ⚠️ +0.03
/error-in-render avg req/sec 2256.61 2194.27 -62.34
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 12.8s 12.8s ⚠️ +38ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Failing test suites

test/integration/config/test/index.test.js

  • Configuration > Rendering via HTTP > renders css imports
  • Configuration > Rendering via HTTP > renders server config on the server only
  • Configuration > Rendering via HTTP > renders the build id in development mode
  • Configuration > Rendering via HTTP > correctly imports a package that defines module but no main in package.json
Expand output

● Configuration › Rendering via HTTP › renders css imports

expect(received).toBe(expected) // Object.is equality

Expected: "Hello World kut"
Received: "Hello World"

  12 |     test('renders css imports', async () => {
  13 |       const $ = await get$('/webpack-css')
> 14 |       expect($('._46QtCORzC4BWRnIseSbG-').text()).toBe('Hello World kut')
     |                                                   ^
  15 |     })
  16 | 
  17 |     test('renders non-js imports from node_modules', async () => {

  at Object.<anonymous> (integration/config/test/rendering.js:14:51)

● Configuration › Rendering via HTTP › renders server config on the server only

expect(received).toBe(expected) // Object.is equality

Expected: "mySecret"
Received: "secret"

  22 |     test('renders server config on the server only', async () => {
  23 |       const $ = await get$('/next-config')
> 24 |       expect($('#server-only').text()).toBe('mySecret')
     |                                        ^
  25 |     })
  26 | 
  27 |     test('renders public config on the server only', async () => {

  at Object.<anonymous> (integration/config/test/rendering.js:24:40)

● Configuration › Rendering via HTTP › renders the build id in development mode

expect(received).toBe(expected) // Object.is equality

Expected: "-"
Received: "development"

  32 |     test('renders the build id in development mode', async () => {
  33 |       const $ = await get$('/build-id')
> 34 |       expect($('#buildId').text()).toBe('-')
     |                                    ^
  35 |     })
  36 | 
  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {

  at Object.<anonymous> (integration/config/test/rendering.js:34:36)

● Configuration › Rendering via HTTP › correctly imports a package that defines module but no main in package.json

expect(received).toBe(expected) // Object.is equality

Expected: "OK"
Received: "I am sometimes found by tooling. I shouldn't be."

  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
  38 |       const $ = await get$('/module-only-content')
> 39 |       expect($('#messageInAPackage').text()).toBe('OK')
     |                                              ^
  40 |     })
  41 |   })
  42 | }

  at Object.<anonymous> (integration/config/test/rendering.js:39:46)

test/integration/app-document/test/index.test.js

  • Document and App > Rendering via HTTP > _document > It injects custom head tags
Expand output

● Document and App › Rendering via HTTP › _document › It injects custom head tags

expect(received).toMatch(expected)

Matcher error: received value must be a string

Received has type:  boolean
Received has value: false

  29 |             .text()
  30 |             .includes()
> 31 |         ).toMatch('body { margin: 0 }')
     |           ^
  32 |       })
  33 | 
  34 |       test('It passes props from Document.getInitialProps to Document', async () => {

  at Object.<anonymous> (integration/app-document/test/rendering.js:31:11)

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Failing test suites

test/integration/config/test/index.test.js

  • Configuration > Rendering via HTTP > renders server config on the server only
  • Configuration > Rendering via HTTP > renders the build id in development mode
  • Configuration > Rendering via HTTP > correctly imports a package that defines module but no main in package.json
Expand output

● Configuration › Rendering via HTTP › renders server config on the server only

expect(received).toBe(expected) // Object.is equality

Expected: "mySecret"
Received: "secret"

  22 |     test('renders server config on the server only', async () => {
  23 |       const $ = await get$('/next-config')
> 24 |       expect($('#server-only').text()).toBe('mySecret')
     |                                        ^
  25 |     })
  26 | 
  27 |     test('renders public config on the server only', async () => {

  at Object.<anonymous> (integration/config/test/rendering.js:24:40)

● Configuration › Rendering via HTTP › renders the build id in development mode

expect(received).toBe(expected) // Object.is equality

Expected: "-"
Received: "development"

  32 |     test('renders the build id in development mode', async () => {
  33 |       const $ = await get$('/build-id')
> 34 |       expect($('#buildId').text()).toBe('-')
     |                                    ^
  35 |     })
  36 | 
  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {

  at Object.<anonymous> (integration/config/test/rendering.js:34:36)

● Configuration › Rendering via HTTP › correctly imports a package that defines module but no main in package.json

expect(received).toBe(expected) // Object.is equality

Expected: "OK"
Received: "I am sometimes found by tooling. I shouldn't be."

  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
  38 |       const $ = await get$('/module-only-content')
> 39 |       expect($('#messageInAPackage').text()).toBe('OK')
     |                                              ^
  40 |     })
  41 |   })
  42 | }

  at Object.<anonymous> (integration/config/test/rendering.js:39:46)

test/integration/app-document/test/index.test.js

  • Document and App > Rendering via HTTP > _document > It injects custom head tags
Expand output

● Document and App › Rendering via HTTP › _document › It injects custom head tags

expect(received).toMatch(expected)

Matcher error: received value must be a string

Received has type:  boolean
Received has value: false

  29 |             .text()
  30 |             .includes()
> 31 |         ).toMatch('body { margin: 0 }')
     |           ^
  32 |       })
  33 | 
  34 |       test('It passes props from Document.getInitialProps to Document', async () => {

  at Object.<anonymous> (integration/app-document/test/rendering.js:31:11)

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 12s 11.4s -669ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall increase ✓
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.937 1.882 -0.06
/ avg req/sec 1290.81 1328.08 ⚠️ +37.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.151 1.142 -0.01
/error-in-render avg req/sec 2171.43 2189.14 ⚠️ +17.71
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 12.6s 12.4s -274ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 11.2s 10.8s -446ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.848 1.904 ⚠️ +0.06
/ avg req/sec 1352.83 1313.35 -39.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.308 1.325 ⚠️ +0.02
/error-in-render avg req/sec 1911.24 1886.79 -24.45
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 11.8s 11.8s -24ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Failing test suites

test/integration/config/test/index.test.js

  • Configuration > Rendering via HTTP > renders server config on the server only
  • Configuration > Rendering via HTTP > renders the build id in development mode
  • Configuration > Rendering via HTTP > correctly imports a package that defines module but no main in package.json
Expand output

● Configuration › Rendering via HTTP › renders server config on the server only

expect(received).toBe(expected) // Object.is equality

Expected: "mySecret"
Received: "secret"

  22 |     test('renders server config on the server only', async () => {
  23 |       const $ = await get$('/next-config')
> 24 |       expect($('#server-only').text()).toBe('mySecret')
     |                                        ^
  25 |     })
  26 | 
  27 |     test('renders public config on the server only', async () => {

  at Object.<anonymous> (integration/config/test/rendering.js:24:40)

● Configuration › Rendering via HTTP › renders the build id in development mode

expect(received).toBe(expected) // Object.is equality

Expected: "-"
Received: "development"

  32 |     test('renders the build id in development mode', async () => {
  33 |       const $ = await get$('/build-id')
> 34 |       expect($('#buildId').text()).toBe('-')
     |                                    ^
  35 |     })
  36 | 
  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {

  at Object.<anonymous> (integration/config/test/rendering.js:34:36)

● Configuration › Rendering via HTTP › correctly imports a package that defines module but no main in package.json

expect(received).toBe(expected) // Object.is equality

Expected: "OK"
Received: "I am sometimes found by tooling. I shouldn't be."

  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
  38 |       const $ = await get$('/module-only-content')
> 39 |       expect($('#messageInAPackage').text()).toBe('OK')
     |                                              ^
  40 |     })
  41 |   })
  42 | }

  at Object.<anonymous> (integration/config/test/rendering.js:39:46)

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 11.9s 11.9s ⚠️ +14ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.992 1.96 -0.03
/ avg req/sec 1255.18 1275.69 ⚠️ +20.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.171 1.236 ⚠️ +0.06
/error-in-render avg req/sec 2134.75 2022.39 -112.36
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 13s 13s ⚠️ +39ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Failing test suites

test/integration/config/test/index.test.js

  • Configuration > Rendering via HTTP > renders the build id in development mode
  • Configuration > Rendering via HTTP > correctly imports a package that defines module but no main in package.json
Expand output

● Configuration › Rendering via HTTP › renders the build id in development mode

expect(received).toBe(expected) // Object.is equality

Expected: "-"
Received: "development"

  32 |     test('renders the build id in development mode', async () => {
  33 |       const $ = await get$('/build-id')
> 34 |       expect($('#buildId').text()).toBe('-')
     |                                    ^
  35 |     })
  36 | 
  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {

  at Object.<anonymous> (integration/config/test/rendering.js:34:36)

● Configuration › Rendering via HTTP › correctly imports a package that defines module but no main in package.json

expect(received).toBe(expected) // Object.is equality

Expected: "OK"
Received: "I am sometimes found by tooling. I shouldn't be."

  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
  38 |       const $ = await get$('/module-only-content')
> 39 |       expect($('#messageInAPackage').text()).toBe('OK')
     |                                              ^
  40 |     })
  41 |   })
  42 | }

  at Object.<anonymous> (integration/config/test/rendering.js:39:46)

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 13.2s 13.2s -54ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall increase ✓
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 2.496 2.227 -0.27
/ avg req/sec 1001.45 1122.54 ⚠️ +121.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.506 1.519 ⚠️ +0.01
/error-in-render avg req/sec 1660.35 1645.52 -14.83
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 14.1s 13.7s -411ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Failing test suites

test/integration/config/test/index.test.js

  • Configuration > Rendering via HTTP > correctly imports a package that defines module but no main in package.json
Expand output

● Configuration › Rendering via HTTP › correctly imports a package that defines module but no main in package.json

expect(received).toBe(expected) // Object.is equality

Expected: "OK"
Received: "I am sometimes found by tooling. I shouldn't be."

  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
  38 |       const $ = await get$('/module-only-content')
> 39 |       expect($('#messageInAPackage').text()).toBe('OK')
     |                                              ^
  40 |     })
  41 |   })
  42 | }

  at Object.<anonymous> (integration/config/test/rendering.js:39:46)

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 13s 12.9s -156ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 2.192 2.191 0
/ avg req/sec 1140.68 1140.8 ⚠️ +0.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.482 1.483 0
/error-in-render avg req/sec 1687.43 1685.22 -2.21
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 13.4s 13.7s ⚠️ +264ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Failing test suites

test/integration/config/test/index.test.js

  • Configuration > Rendering via HTTP > correctly imports a package that defines module but no main in package.json
Expand output

● Configuration › Rendering via HTTP › correctly imports a package that defines module but no main in package.json

expect(received).toBe(expected) // Object.is equality

Expected: "OK"
Received: "I am sometimes found by tooling. I shouldn't be."

  37 |     test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
  38 |       const $ = await get$('/module-only-content')
> 39 |       expect($('#messageInAPackage').text()).toBe('OK')
     |                                              ^
  40 |     })
  41 |   })
  42 | }

  at Object.<anonymous> (integration/config/test/rendering.js:39:46)

@Janpot Janpot marked this pull request as ready for review May 17, 2020 14:59
@Janpot Janpot changed the title Run eslint-plugin-jest Add eslint-plugin-jest May 17, 2020
@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 8.9s 8.9s -39ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall increase ✓
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.525 1.507 -0.02
/ avg req/sec 1639.28 1659.25 ⚠️ +19.97
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 0.832 0.829 0
/error-in-render avg req/sec 3004.38 3013.95 ⚠️ +9.57
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 9.5s 9.5s -45ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

package.json Outdated Show resolved Hide resolved
test/integration/config/test/rendering.js Outdated Show resolved Hide resolved
@Timer Timer added this to the 9.4.2 milestone May 17, 2020
@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 9.8s 9.8s -43ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.61 1.704 ⚠️ +0.09
/ avg req/sec 1553.08 1467.5 -85.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 0.956 1.019 ⚠️ +0.06
/error-in-render avg req/sec 2614.76 2452.8 -161.96
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 10.2s 11.3s ⚠️ +1.1s
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 12s 11.5s -493ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.918 1.891 -0.03
/ avg req/sec 1303.14 1321.77 ⚠️ +18.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.123 1.163 ⚠️ +0.04
/error-in-render avg req/sec 2226.12 2149.01 -77.11
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 12.8s 13s ⚠️ +174ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 11.7s 11.7s -23ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.903 1.892 -0.01
/ avg req/sec 1313.81 1321.3 ⚠️ +7.49
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.098 1.154 ⚠️ +0.06
/error-in-render avg req/sec 2276.09 2166.84 -109.25
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 12.6s 12.3s -280ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 11.1s 11.4s ⚠️ +321ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.775 1.814 ⚠️ +0.04
/ avg req/sec 1408.46 1378.04 -30.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.078 1.073 -0.01
/error-in-render avg req/sec 2319.66 2329.27 ⚠️ +9.61
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 11.9s 11.6s -261ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 13.5s 13.8s ⚠️ +297ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 2.337 2.41 ⚠️ +0.07
/ avg req/sec 1069.72 1037.45 -32.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.582 1.691 ⚠️ +0.11
/error-in-render avg req/sec 1580.56 1478.28 -102.28
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.7 kB 6.7 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..310a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.73 kB 5.73 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.86 kB 6.86 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 928 B 928 B
link.html gzip 937 B 937 B
withRouter.html gzip 924 B 924 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 15.1s 15.6s ⚠️ +482ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.7 kB 6.7 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..310a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.73 kB 5.73 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.86 kB 6.86 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 11.9s 11.9s -6ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.996 2.019 ⚠️ +0.02
/ avg req/sec 1252.57 1238.07 -14.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.123 1.198 ⚠️ +0.07
/error-in-render avg req/sec 2227.03 2086.98 -140.05
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.7 kB 6.7 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..310a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.73 kB 5.73 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.86 kB 6.86 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
index.html gzip 928 B 928 B
link.html gzip 937 B 937 B
withRouter.html gzip 924 B 924 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
buildDuration 13s 13s ⚠️ +29ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.js gzip 6.7 kB 6.7 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..310a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
main-HASH.module.js gzip 5.73 kB 5.73 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.86 kB 6.86 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js run-eslint-plugin-jest Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@Janpot
Copy link
Contributor Author

Janpot commented May 18, 2020

Ok, this is ready

@Timer Timer merged commit 7147479 into vercel:canary May 18, 2020
@Janpot Janpot deleted the run-eslint-plugin-jest branch May 18, 2020 17:19
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants