Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nomodule polyfills and suggest using features only up to ES2019 for browser compatibility #15772

Merged
merged 25 commits into from
Aug 4, 2020

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Aug 1, 2020

These changes aim to resolve most of the concerns raised in #15756. It adds missing polyfills for legacy browsers up until ES2019:

  • Number.{parseFloat,parseInt}
  • Math.{acosh,asinh,atanh,cbrt,clz32,cosh,expm1,fround,hypot,imul,log10p,log1p,log2,sign,sinh,tanh,trunc} [Removed as these are not widely used]
    • While these may seem to weigh a lot, they barely add 1 kB to the resulting bundle:
      gzip: 32 kB vs. 30.9 kB, Brotli: 28.8 kB vs. 27.8 kB
  • Object.fromEntries [Removed as it's rarely used in user code]

Also, the following features are now supported with build-time transforms:

The suggested TypeScript library version has been set to ES2018, so the features below become unavailable in type-checked files (they're not evenly supported by module-compatible browsers, either):

  • Object.fromEntries
  • String.prototype.matchAll
  • String.prototype.replaceAll
  • Promise.any + AggregateError
  • WeakRef

As for the import.meta support, webpack v5 seems to fix that, so it should eventually become an issue of the past.


Fixes #15756

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 11.6s 11.8s ⚠️ +243ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +11.2 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.145 2.436 ⚠️ +0.29
/ avg req/sec 1165.71 1026.15 ⚠️ -139.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.396 1.542 ⚠️ +0.15
/error-in-render avg req/sec 1790.87 1620.92 ⚠️ -169.95
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB 32.1 kB ⚠️ +1.27 kB
Overall change 30.8 kB 32.1 kB ⚠️ +1.27 kB
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 948 B 948 B
link.html gzip 953 B 954 B ⚠️ +1 B
withRouter.html gzip 940 B 940 B
Overall change 2.84 kB 2.84 kB ⚠️ +1 B

Diffs

Diff for polyfills-cd..400b29b58.js
failed to diff
Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-ccc713b526df21a39ab0.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-ccc713b526df21a39ab0.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-ccc713b526df21a39ab0.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 12.9s 13.4s ⚠️ +556ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +11.2 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB N/A N/A
polyfills-3c..319d.js gzip N/A 32.1 kB N/A
Overall change 30.8 kB 32.1 kB ⚠️ +1.27 kB
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 93bd1a5

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Failing test suites

Commit: 93bd1a5

test/integration/size-limit/test/index.test.js

  • Production response size > should not increase the overall response size of default build
Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeLessThanOrEqual(expected)

Expected: <= 1024
Received:    3323

  82 |     // These numbers are without gzip compression!
  83 |     const delta = responseSizesBytes - 275 * 1024
> 84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
     |                   ^
  85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
  86 |   })
  87 | 

  at Object.<anonymous> (integration/size-limit/test/index.test.js:84:19)

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 11.5s 12.1s ⚠️ +637ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +11 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.057 2.064 ⚠️ +0.01
/ avg req/sec 1215.62 1211.08 ⚠️ -4.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.142 1.131 -0.01
/error-in-render avg req/sec 2188.66 2209.83 +21.17
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB 32.1 kB ⚠️ +1.28 kB
Overall change 30.8 kB 32.1 kB ⚠️ +1.28 kB
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Rendered Page Sizes
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 948 B 946 B -2 B
link.html gzip 953 B 954 B ⚠️ +1 B
withRouter.html gzip 940 B 941 B ⚠️ +1 B
Overall change 2.84 kB 2.84 kB

Diffs

Diff for polyfills-cd..400b29b58.js
failed to diff
Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-875d0e51ab4bf3f9d92e.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-875d0e51ab4bf3f9d92e.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-875d0e51ab4bf3f9d92e.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.2s 13.5s ⚠️ +295ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +11 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB N/A N/A
polyfills-48..eb5e.js gzip N/A 32.1 kB N/A
Overall change 30.8 kB 32.1 kB ⚠️ +1.28 kB
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 653e58e

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Failing test suites

Commit: 653e58e

test/integration/tsconfig-verifier/test/index.test.js

  • tsconfig.json verifier > Creates a default tsconfig.json when one is missing
  • tsconfig.json verifier > Works with an empty tsconfig.json (docs)
  • tsconfig.json verifier > Updates an existing tsconfig.json without losing comments
  • tsconfig.json verifier > allows you to set commonjs module mode
  • tsconfig.json verifier > allows you to set es2020 module mode
Expand output

● tsconfig.json verifier › Creates a default tsconfig.json when one is missing

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier Creates a default tsconfig.json when one is missing 1`

- Snapshot  - 1
+ Received  + 1

@@ -2,11 +2,11 @@
    "compilerOptions": {
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2019"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  24 |     const { code } = await nextBuild(appDir)
  25 |     expect(code).toBe(0)
> 26 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
     |                                              ^
  27 |       "{
  28 |         \\"compilerOptions\\": {
  29 |           \\"target\\": \\"es5\\",

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:26:46)

● tsconfig.json verifier › Works with an empty tsconfig.json (docs)

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier Works with an empty tsconfig.json (docs) 1`

- Snapshot  - 1
+ Received  + 1

@@ -2,11 +2,11 @@
    "compilerOptions": {
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2019"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  68 |     expect(code).toBe(0)
  69 | 
> 70 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
     |                                              ^
  71 |       "{
  72 |         \\"compilerOptions\\": {
  73 |           \\"target\\": \\"es5\\",

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:70:46)

● tsconfig.json verifier › Updates an existing tsconfig.json without losing comments

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier Updates an existing tsconfig.json without losing comments 1`

- Snapshot  - 1
+ Received  + 1

@@ -9,11 +9,11 @@
      ,
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2019"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  128 |     // Weird comma placement until this issue is resolved:
  129 |     // https://github.com/kaelzhang/node-comment-json/issues/21
> 130 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
      |                                              ^
  131 |       "// top-level comment
  132 |       {
  133 |         // in-object comment 1

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:130:46)

● tsconfig.json verifier › allows you to set commonjs module mode

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier allows you to set commonjs module mode 1`

- Snapshot  - 1
+ Received  + 1

@@ -4,11 +4,11 @@
      "module": "commonjs",
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2019"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  181 |     expect(code).toBe(0)
  182 | 
> 183 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
      |                                              ^
  184 |       "{
  185 |         \\"compilerOptions\\": {
  186 |           \\"esModuleInterop\\": true,

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:183:46)

● tsconfig.json verifier › allows you to set es2020 module mode

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier allows you to set es2020 module mode 1`

- Snapshot  - 1
+ Received  + 1

@@ -4,11 +4,11 @@
      "module": "es2020",
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2019"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  226 |     expect(code).toBe(0)
  227 | 
> 228 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
      |                                              ^
  229 |       "{
  230 |         \\"compilerOptions\\": {
  231 |           \\"esModuleInterop\\": true,

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:228:46)

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.2s 13.4s ⚠️ +200ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +10.9 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.364 2.51 ⚠️ +0.15
/ avg req/sec 1057.31 995.89 ⚠️ -61.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.473 1.471 0
/error-in-render avg req/sec 1697.08 1699.12 +2.04
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB 32.1 kB ⚠️ +1.25 kB
Overall change 30.8 kB 32.1 kB ⚠️ +1.25 kB
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 948 B 948 B
link.html gzip 953 B 953 B
withRouter.html gzip 940 B 941 B ⚠️ +1 B
Overall change 2.84 kB 2.84 kB ⚠️ +1 B

Diffs

Diff for polyfills-cd..400b29b58.js
failed to diff
Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-9d08b58b922d8d7356d4.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-9d08b58b922d8d7356d4.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-9d08b58b922d8d7356d4.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 14.8s 14.9s ⚠️ +173ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +10.9 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB N/A N/A
polyfills-67..2961.js gzip N/A 32.1 kB N/A
Overall change 30.8 kB 32.1 kB ⚠️ +1.25 kB
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 51112b1

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Failing test suites

Commit: 51112b1

test/integration/size-limit/test/index.test.js

  • Production response size > should not increase the overall response size of default build
Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeLessThanOrEqual(expected)

Expected: <= 1024
Received:    3221

  82 |     // These numbers are without gzip compression!
  83 |     const delta = responseSizesBytes - 275 * 1024
> 84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
     |                   ^
  85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
  86 |   })
  87 | 

  at Object.<anonymous> (integration/size-limit/test/index.test.js:84:19)

test/integration/tsconfig-verifier/test/index.test.js

  • tsconfig.json verifier > Creates a default tsconfig.json when one is missing
  • tsconfig.json verifier > Works with an empty tsconfig.json (docs)
  • tsconfig.json verifier > Updates an existing tsconfig.json without losing comments
  • tsconfig.json verifier > allows you to set commonjs module mode
  • tsconfig.json verifier > allows you to set es2020 module mode
Expand output

● tsconfig.json verifier › Creates a default tsconfig.json when one is missing

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier Creates a default tsconfig.json when one is missing 1`

- Snapshot  - 1
+ Received  + 1

@@ -2,11 +2,11 @@
    "compilerOptions": {
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2018"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  24 |     const { code } = await nextBuild(appDir)
  25 |     expect(code).toBe(0)
> 26 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
     |                                              ^
  27 |       "{
  28 |         \\"compilerOptions\\": {
  29 |           \\"target\\": \\"es5\\",

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:26:46)

● tsconfig.json verifier › Works with an empty tsconfig.json (docs)

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier Works with an empty tsconfig.json (docs) 1`

- Snapshot  - 1
+ Received  + 1

@@ -2,11 +2,11 @@
    "compilerOptions": {
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2018"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  68 |     expect(code).toBe(0)
  69 | 
> 70 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
     |                                              ^
  71 |       "{
  72 |         \\"compilerOptions\\": {
  73 |           \\"target\\": \\"es5\\",

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:70:46)

● tsconfig.json verifier › Updates an existing tsconfig.json without losing comments

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier Updates an existing tsconfig.json without losing comments 1`

- Snapshot  - 1
+ Received  + 1

@@ -9,11 +9,11 @@
      ,
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2018"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  128 |     // Weird comma placement until this issue is resolved:
  129 |     // https://github.com/kaelzhang/node-comment-json/issues/21
> 130 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
      |                                              ^
  131 |       "// top-level comment
  132 |       {
  133 |         // in-object comment 1

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:130:46)

● tsconfig.json verifier › allows you to set commonjs module mode

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier allows you to set commonjs module mode 1`

- Snapshot  - 1
+ Received  + 1

@@ -4,11 +4,11 @@
      "module": "commonjs",
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2018"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  181 |     expect(code).toBe(0)
  182 | 
> 183 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
      |                                              ^
  184 |       "{
  185 |         \\"compilerOptions\\": {
  186 |           \\"esModuleInterop\\": true,

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:183:46)

● tsconfig.json verifier › allows you to set es2020 module mode

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `tsconfig.json verifier allows you to set es2020 module mode 1`

- Snapshot  - 1
+ Received  + 1

@@ -4,11 +4,11 @@
      "module": "es2020",
      "target": "es5",
      "lib": [
        "dom",
        "dom.iterable",
-       "esnext"
+       "es2018"
      ],
      "allowJs": true,
      "skipLibCheck": true,
      "strict": false,
      "forceConsistentCasingInFileNames": true,

  226 |     expect(code).toBe(0)
  227 | 
> 228 |     expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
      |                                              ^
  229 |       "{
  230 |         \\"compilerOptions\\": {
  231 |           \\"esModuleInterop\\": true,

  at Object.<anonymous> (integration/tsconfig-verifier/test/index.test.js:228:46)

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.8s 14.3s ⚠️ +518ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +8.03 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.642 2.643 0
/ avg req/sec 946.37 945.91 ⚠️ -0.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.568 1.491 -0.08
/error-in-render avg req/sec 1594.2 1676.27 +82.07
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 948 B 948 B
link.html gzip 953 B 954 B ⚠️ +1 B
withRouter.html gzip 940 B 940 B
Overall change 2.84 kB 2.84 kB ⚠️ +1 B

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 15.7s 15.5s -238ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +8.03 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB N/A N/A
polyfills-0a..088e.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: f88f19e

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 12.3s 12.5s ⚠️ +145ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +8.03 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.291 2.128 -0.16
/ avg req/sec 1091.06 1175.07 +84.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.267 1.213 -0.05
/error-in-render avg req/sec 1973.43 2060.37 +86.94
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 948 B 948 B
link.html gzip 953 B 954 B ⚠️ +1 B
withRouter.html gzip 940 B 940 B
Overall change 2.84 kB 2.84 kB ⚠️ +1 B

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.9s 14s ⚠️ +107ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +8.03 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB N/A N/A
polyfills-0a..088e.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: d63e4d0

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 12.2s 12.2s ⚠️ +11ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.234 2.194 -0.04
/ avg req/sec 1119.12 1139.32 +20.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.405 1.387 -0.02
/error-in-render avg req/sec 1779.74 1802.31 +22.57
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..39a4.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 946 B 947 B ⚠️ +1 B
link.html gzip 952 B 952 B
withRouter.html gzip 939 B 939 B
Overall change 2.84 kB 2.84 kB ⚠️ +1 B

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.3s 13.8s ⚠️ +472ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..39a4.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB N/A N/A
polyfills-0a..088e.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 76a6902

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.5s 13.2s -337ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.536 2.456 -0.08
/ avg req/sec 985.77 1017.91 +32.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.542 1.467 -0.07
/error-in-render avg req/sec 1621.3 1704.61 +83.31
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..39a4.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 946 B 947 B ⚠️ +1 B
link.html gzip 952 B 952 B
withRouter.html gzip 939 B 939 B
Overall change 2.84 kB 2.84 kB ⚠️ +1 B

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-11db2adbacdc8afcd350.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 15.3s 15.1s -119ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..39a4.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB
webpack-488d..c0e7.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB
webpack-4f62..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-05..1236.js gzip 30.8 kB N/A N/A
polyfills-0a..088e.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB
hooks-f7f3d0..7465.js gzip 887 B 887 B
index-08fb3f..c0e9.js gzip 227 B 227 B
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB
routerDirect..8aa1.js gzip 284 B 284 B
withRouter-f..e777.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-669dbe5..dule.js gzip 626 B 626 B
_error-d5979..dule.js gzip 2.3 kB 2.3 kB
hooks-805c40..dule.js gzip 387 B 387 B
index-6ba5a4..dule.js gzip 226 B 226 B
link-91516ae..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-d..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 274 B 274 B
_buildManife..dule.js gzip 282 B 282 B
Overall change 556 B 556 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 67c3162

@kripod
Copy link
Contributor Author

kripod commented Aug 3, 2020

@timneutkens May I help with anything to advance the state of this PR? 😊

@timneutkens
Copy link
Member

@timneutkens May I help with anything to advance the state of this PR? 😊

Overall it looks great now, just needs one more test 🙏

@ijjk
Copy link
Member

ijjk commented Aug 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 12.4s 12.5s ⚠️ +125ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.232 2.229 0
/ avg req/sec 1120.24 1121.37 +1.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.209 1.218 ⚠️ +0.01
/error-in-render avg req/sec 2067.14 2052.09 ⚠️ -15.05
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5932771..4350.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-02cf3f6..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 944 B 945 B ⚠️ +1 B
link.html gzip 953 B 953 B
withRouter.html gzip 939 B 938 B -1 B
Overall change 2.84 kB 2.84 kB

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.4s 13.5s ⚠️ +81ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5932771..4350.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-02cf3f6..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB N/A N/A
polyfills-75..1629.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 0ebf4df

@ijjk
Copy link
Member

ijjk commented Aug 3, 2020

Failing test suites

Commit: b39ef9a

test/integration/babel/test/index.test.js

  • Babel > Rendering via HTTP > Should compile a page with flowtype correctly
Expand output

● Babel › Rendering via HTTP › Should compile a page with flowtype correctly

expect(received).toBe(expected) // Object.is equality

Expected: "Test Babel"
Received: ""

  12 |     it('Should compile a page with flowtype correctly', async () => {
  13 |       const $ = await get$('/')
> 14 |       expect($('#text').text()).toBe('Test Babel')
     |                                 ^
  15 |     })
  16 |   })
  17 | }

  at Object.<anonymous> (integration/babel/test/rendering.js:14:33)

@ijjk
Copy link
Member

ijjk commented Aug 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 12s 11.8s -219ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.133 2.135 0
/ avg req/sec 1172.06 1171.15 ⚠️ -0.91
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.143 1.133 -0.01
/error-in-render avg req/sec 2187.4 2207.15 +19.75
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5932771..4350.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-02cf3f6..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 944 B 945 B ⚠️ +1 B
link.html gzip 953 B 953 B
withRouter.html gzip 939 B 938 B -1 B
Overall change 2.84 kB 2.84 kB

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.3s 13.3s ⚠️ +4ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5932771..4350.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-02cf3f6..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB N/A N/A
polyfills-75..1629.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: b39ef9a

@ijjk
Copy link
Member

ijjk commented Aug 3, 2020

Failing test suites

Commit: 788c0a0

test/integration/babel/test/index.test.js

  • Babel > Rendering via HTTP > Should compile a page with flowtype correctly
Expand output

● Babel › Rendering via HTTP › Should compile a page with flowtype correctly

expect(received).toBe(expected) // Object.is equality

Expected: "Test Babel"
Received: ""

  12 |     it('Should compile a page with flowtype correctly', async () => {
  13 |       const $ = await get$('/')
> 14 |       expect($('#text').text()).toBe('Test Babel')
     |                                 ^
  15 |     })
  16 |   })
  17 | }

  at Object.<anonymous> (integration/babel/test/rendering.js:14:33)

@ijjk
Copy link
Member

ijjk commented Aug 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 11.9s 12s ⚠️ +99ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.115 2.174 ⚠️ +0.06
/ avg req/sec 1182.17 1149.79 ⚠️ -32.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.175 1.194 ⚠️ +0.02
/error-in-render avg req/sec 2127.58 2094.1 ⚠️ -33.48
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5932771..4350.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-02cf3f6..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 944 B 945 B ⚠️ +1 B
link.html gzip 953 B 953 B
withRouter.html gzip 939 B 938 B -1 B
Overall change 2.84 kB 2.84 kB

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.1s 13.1s -36ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5932771..4350.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-02cf3f6..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB N/A N/A
polyfills-75..1629.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 788c0a0

@ijjk
Copy link
Member

ijjk commented Aug 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 11.9s 12.5s ⚠️ +560ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.208 2.323 ⚠️ +0.11
/ avg req/sec 1132.5 1076.13 ⚠️ -56.37
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.351 1.371 ⚠️ +0.02
/error-in-render avg req/sec 1851.04 1823.77 ⚠️ -27.27
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5932771..4350.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-02cf3f6..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 944 B 945 B ⚠️ +1 B
link.html gzip 953 B 953 B
withRouter.html gzip 939 B 938 B -1 B
Overall change 2.84 kB 2.84 kB

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-e794a53192c4e30a4257.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13s 14s ⚠️ +970ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5932771..4350.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-02cf3f6..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB N/A N/A
polyfills-75..1629.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 98b4076

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ijjk
Copy link
Member

ijjk commented Aug 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 13.1s 13.1s ⚠️ +30ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
/ failed reqs 0 0
/ total time (seconds) 2.404 2.426 ⚠️ +0.02
/ avg req/sec 1040 1030.48 ⚠️ -9.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.433 1.526 ⚠️ +0.09
/error-in-render avg req/sec 1744.69 1638.38 ⚠️ -106.31
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-25d7dba..750c.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-942ecf5..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB 31 kB ⚠️ +197 B
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
index.html gzip 945 B 946 B ⚠️ +1 B
link.html gzip 954 B 955 B ⚠️ +1 B
withRouter.html gzip 940 B 940 B
Overall change 2.84 kB 2.84 kB ⚠️ +2 B

Diffs

Diff for polyfills-cd..400b29b58.js

Diff too large to display

Diff for index.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-1c1c12a4c3b8315d4912.js"
Diff for link.html
@@ -83,7 +83,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-1c1c12a4c3b8315d4912.js"
Diff for withRouter.html
@@ -78,7 +78,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-cdbbd579644400b29b58.js"
+      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
       src="/_next/static/chunks/main-1c1c12a4c3b8315d4912.js"

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
buildDuration 14.4s 14.9s ⚠️ +454ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +7.85 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-25d7dba..750c.js gzip 6.73 kB 6.73 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-942ecf5..dule.js gzip 5.81 kB 5.81 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary kripod/next.js fix-browser-compat Change
polyfills-4c..dbb6.js gzip 30.8 kB N/A N/A
polyfills-75..1629.js gzip N/A 31 kB N/A
Overall change 30.8 kB 31 kB ⚠️ +197 B
Client Pages
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-e97733c..af21.js gzip 1.3 kB 1.3 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.72 kB 7.72 kB
Client Pages Modern
vercel/next.js canary kripod/next.js fix-browser-compat Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary kripod/next.js fix-browser-compat Change
_buildManifest.js gzip 272 B 272 B
_buildManife..dule.js gzip 280 B 280 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary kripod/next.js fix-browser-compat Change
_error.js 1.02 MB 1.02 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.02 MB 1.02 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.2 MB 5.2 MB
Commit: 076c027

@kodiakhq kodiakhq bot merged commit aef6726 into vercel:canary Aug 4, 2020
@kripod kripod deleted the fix-browser-compat branch August 4, 2020 06:09
@timneutkens
Copy link
Member

Thanks @kripod! Great PR 👍

kodiakhq bot pushed a commit that referenced this pull request May 18, 2021
…tes.ts` (#25208)

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added

Fixes #25207

Currently rewritten routes that use a `has` condition throw an `Object.fromEntries is not a function` error in older browsers.

## Documentation / Examples

- [x] Make sure the linting passes

## Solution

As mentioned in issue #25207, looks like last year the team decided not to include the `fromEntries` polyfill #15772 (comment).

As such, we should avoid using non-polyfilled methods in core next.js code bundled in the browser.

This PR's changes should result in the same object being returned, without using `fromEntries`.
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
…tes.ts` (vercel#25208)

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added

Fixes vercel#25207

Currently rewritten routes that use a `has` condition throw an `Object.fromEntries is not a function` error in older browsers.

## Documentation / Examples

- [x] Make sure the linting passes

## Solution

As mentioned in issue vercel#25207, looks like last year the team decided not to include the `fromEntries` polyfill vercel#15772 (comment).

As such, we should avoid using non-polyfilled methods in core next.js code bundled in the browser.

This PR's changes should result in the same object being returned, without using `fromEntries`.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing polyfills and transforms for older browsers
5 participants