Add pnpm integration test #17882

elliottsj · 2020-10-14T15:04:55Z

Ported from #16369

Improve the pnpm integration test by installing dependencies and building the Next.js app in an isolated, temporary directory. Improve isolation when installing the "next" package by packing it into a tarball first, to avoid symlinking to next.js/packages/next.

Upgrade pnpm to the latest release.

ijjk · 2020-10-14T15:16:39Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	13.9s	14.5s	⚠️ +639ms
nodeModulesSize	63.4 MB	63.4 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.637	2.867	⚠️ +0.23
/ avg req/sec	948.1	871.95	⚠️ -76.15
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.561	1.706	⚠️ +0.15
/error-in-render avg req/sec	1601.31	1465.53	⚠️ -135.78

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3fae807..efe0.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8ac5189..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	15.6s	15.9s	⚠️ +324ms
nodeModulesSize	63.4 MB	63.4 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3fae807..efe0.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8ac5189..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: 9e9c48b

clayrisser · 2020-10-14T22:10:16Z

I am very excited about this pull request. I can't wait for it to get accepted. Thank you all for the hard work put into this.

timneutkens · 2020-10-15T13:05:34Z

test/package-managers/pnpm/test/index.test.js

+async function packNextTarball(cwd) {
+  const { stdout } = await runNpm(
+    cwd,
+    'pack',


Just to make sure, does this cover bundling the dependencies needed like @next/react-dev-overlay as well?

This is a good point. Just checked and it seems that only the "next" package is packed, not the other monorepo dependencies like @next/polyfill-module, @next/react-dev-overlay.

I pushed an change which packs @next/env, @next/polyfill-module, @next/react-dev-overlay, and @next/react-refresh-utils into tarballs too, and ensures they're installed upon running pnpm install by using a pnpmfile.js hook.

This is the best I could come up with to make the install process as similar as possible to the real world (installing from a registry), without actually installing from a registry.

An even more correct pnpm test would involve publishing all of the monorepo packages to a local npm registry (maybe verdaccio?), then telling pnpm to install packages from there. Would something like this be preferred?

pnpm has a new package.json overrides feature in v5.10.1, so I upgraded and switched to that. It's a bit cleaner now, since we don't have to generate an executable pnpmfile.js file anymore.

Nice! 💯 Will re-review this PR soon!

@timneutkens thanks. Can't wait for this.

ijjk · 2020-10-18T03:56:44Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	13.7s	13.8s	⚠️ +92ms
nodeModulesSize	64.4 MB	64.4 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.519	2.522	0
/ avg req/sec	992.45	991.42	⚠️ -1.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.405	1.361	-0.04
/error-in-render avg req/sec	1779.19	1836.87	+57.68

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..7765.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-5aa1543..4e79.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-7d849dd..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	15.7s	15.8s	⚠️ +120ms
nodeModulesSize	64.4 MB	64.4 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..7765.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-5aa1543..4e79.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-7d849dd..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: 34c1f49

ijjk · 2020-10-24T23:20:10Z

Stats from current PR

Default Server Mode

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	12.7s	12.3s	-421ms
nodeModulesSize	91.3 MB	91.3 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.34	2.345	⚠️ +0.01
/ avg req/sec	1068.52	1066.15	⚠️ -2.37
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.276	1.273	0
/error-in-render avg req/sec	1959.22	1963.89	+4.67

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3dd37a4..54de.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-082aff9..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	994 B	994 B	✓
Overall change	3 kB	3 kB	✓

Serverless Mode

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	14.3s	14.2s	-142ms
nodeModulesSize	91.3 MB	91.3 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..574c.js gzip	11.2 kB	11.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3dd37a4..54de.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..dule.js gzip	7.02 kB	7.02 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-082aff9..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: b4d23aa

remorses · 2020-10-28T09:27:59Z

thank you @elliottsj for fixing my tests 👍

Use 'npm' to pack the tarball, write it to temp dir Using npm allows us to skip the prepublish script by passing '--ignore-scripts' (pnpm doesn't support this). Write the .tgz file to the temp dir, to avoid conflicting with other concurrent tests which may read files in 'packages/next/'

ijjk · 2020-12-26T19:12:52Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	10.3s	10.2s	-33ms
nodeModulesSize	82.6 MB	82.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.034	2.048	⚠️ +0.01
/ avg req/sec	1229.01	1220.49	⚠️ -8.52
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.258	1.208	-0.05
/error-in-render avg req/sec	1987.74	2068.92	+81.18

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
index.html gzip	612 B	612 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	12.1s	11.9s	-137ms
nodeModulesSize	82.6 MB	82.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 23e6431

Avoid "TypeError: Object.fromEntries is not a function" in Azure/Windows tests

ijjk · 2020-12-26T21:36:50Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	11.7s	11.4s	-342ms
nodeModulesSize	82.6 MB	82.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.526	2.381	-0.15
/ avg req/sec	989.72	1049.78	+60.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.78	1.792	⚠️ +0.01
/error-in-render avg req/sec	1404.86	1395.26	⚠️ -9.6

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
index.html gzip	612 B	612 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	13.6s	13.9s	⚠️ +309ms
nodeModulesSize	82.6 MB	82.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 6be3048

ijjk · 2021-01-02T19:27:05Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	10.3s	10.3s	-4ms
nodeModulesSize	80.6 MB	80.6 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.101	2.089	-0.01
/ avg req/sec	1190.06	1196.49	+6.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.316	1.347	⚠️ +0.03
/error-in-render avg req/sec	1900.33	1855.48	⚠️ -44.85

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..42af.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a9a6f0d..a96d.js gzip	6.59 kB	6.59 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.3 kB	59.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-cfcb6..fe1c.js gzip	3.44 kB	3.44 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.08 kB	8.08 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
index.html gzip	615 B	615 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	12.3s	12.5s	⚠️ +120ms
nodeModulesSize	80.6 MB	80.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..42af.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a9a6f0d..a96d.js gzip	6.59 kB	6.59 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.3 kB	59.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-cfcb6..fe1c.js gzip	3.44 kB	3.44 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.08 kB	8.08 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.17 MB	5.17 MB	✓

Commit: 8fe0664

clayrisser · 2021-01-08T01:42:53Z

What needs to be done to get this pull request accepted?

ijjk · 2021-01-08T18:44:32Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	9.2s	9s	-221ms
nodeModulesSize	80.8 MB	80.8 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.792	1.753	-0.04
/ avg req/sec	1395.26	1426.08	+30.82
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.133	1.175	⚠️ +0.04
/error-in-render avg req/sec	2206.2	2128.11	⚠️ -78.09

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
buildDuration	10.6s	10.7s	⚠️ +76ms
nodeModulesSize	80.8 MB	80.8 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	elliottsj/next.js pnpm-integration-test	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 510ed40

timneutkens · 2021-01-11T10:36:44Z

This looks good to land now 👍

elliottsj · 2021-01-11T16:45:42Z

@timneutkens Thanks. I'm not 100% sure if the CI errors are due to my changes, but they seem unrelated:

https://github.com/vercel/next.js/pull/17882/checks?check_run_id=1670448416

$ tsc --declaration --emitDeclarationOnly --declarationDir dist
../../node_modules/webpack/types.d.ts(1758,5): error TS2411: Property 'byLayer' of type '{ [index: string]: ExternalItem; } | ((layer: string | null) => ExternalItem) | undefined' is not assignable to string index type 'string | boolean | string[] | { [index: string]: any; }'.
../../node_modules/webpack/types.d.ts(3236,4): error TS2411: Property 'byLayer' of type '{ [index: string]: ExternalItem; } | ((layer: string | null) => ExternalItem) | undefined' is not assignable to string index type 'string | boolean | string[] | { [index: string]: any; }'.
...

https://dev.azure.com/nextjs/next.js/_build/results?buildId=23397&view=logs&j=460b0bb8-e204-5472-659f-852468662db0&t=8e085f73-555e-5832-fbf3-56058ddf3f17&l=32508

FAIL test/integration/ssg-data-404/test/index.test.js (17.29s)


  ● Test suite failed to run

    read ECONNRESET

Let me know if I need to change anything.

timneutkens · 2021-01-11T16:50:19Z

Yeah that's unrelated!

elliottsj requested review from ijjk, lfades, Timer and timneutkens as code owners October 14, 2020 15:04

elliottsj mentioned this pull request Oct 14, 2020

Follow symlinks in resolveRequest #16369

Closed

timneutkens reviewed Oct 15, 2020

View reviewed changes

elliottsj requested a review from timneutkens October 18, 2020 16:29

elliottsj force-pushed the pnpm-integration-test branch from 34c1f49 to b4d23aa Compare October 24, 2020 23:10

elliottsj mentioned this pull request Nov 30, 2020

Not working with PNPM #16471

Closed

elliottsj added 6 commits December 26, 2020 14:00

Upgrade pnpm to latest

531c55a

Replace 'basic-pnpm' test

3747ebf

Ensure "next"'s monorepo dependencies are installed

840a8cb

Update pnpm to latest

0e8d649

Replace pnpmfile.js with "pnpm.overrides"

23e6431

elliottsj force-pushed the pnpm-integration-test branch from b4d23aa to 23e6431 Compare December 26, 2020 19:03

vercel bot temporarily deployed to Preview December 26, 2020 19:03 Inactive

Replace Object.fromEntries with for loop

6be3048

Avoid "TypeError: Object.fromEntries is not a function" in Azure/Windows tests

vercel bot temporarily deployed to Preview December 26, 2020 21:26 Inactive

Merge branch 'canary' into pnpm-integration-test

8fe0664

Merge upstream/canary into pnpm-integration-test

94e9840

Upgrade to pnpm@5.14.3

510ed40

elliottsj force-pushed the pnpm-integration-test branch from 798874e to 510ed40 Compare January 8, 2021 18:36

vasiliicuhar mentioned this pull request Jan 10, 2021

ENOENT build error with Vercel + pnpm #20948

Closed

timneutkens approved these changes Jan 11, 2021

View reviewed changes

timneutkens merged commit 16ff439 into vercel:canary Jan 11, 2021

elliottsj deleted the pnpm-integration-test branch January 11, 2021 16:54

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pnpm integration test #17882

Add pnpm integration test #17882

elliottsj commented Oct 14, 2020

ijjk commented Oct 14, 2020

clayrisser commented Oct 14, 2020

timneutkens Oct 15, 2020

elliottsj Oct 18, 2020

elliottsj Oct 27, 2020

timneutkens Oct 28, 2020

clayrisser Nov 30, 2020

ijjk commented Oct 18, 2020

ijjk commented Oct 24, 2020

remorses commented Oct 28, 2020

ijjk commented Dec 26, 2020

ijjk commented Dec 26, 2020

ijjk commented Jan 2, 2021

clayrisser commented Jan 8, 2021

ijjk commented Jan 8, 2021

timneutkens commented Jan 11, 2021

elliottsj commented Jan 11, 2021

timneutkens commented Jan 11, 2021

Add pnpm integration test #17882

Add pnpm integration test #17882

Conversation

elliottsj commented Oct 14, 2020

ijjk commented Oct 14, 2020

Stats from current PR

clayrisser commented Oct 14, 2020

timneutkens Oct 15, 2020

Choose a reason for hiding this comment

elliottsj Oct 18, 2020

Choose a reason for hiding this comment

elliottsj Oct 27, 2020

Choose a reason for hiding this comment

timneutkens Oct 28, 2020

Choose a reason for hiding this comment

clayrisser Nov 30, 2020

Choose a reason for hiding this comment

ijjk commented Oct 18, 2020

Stats from current PR

ijjk commented Oct 24, 2020

Stats from current PR

remorses commented Oct 28, 2020

ijjk commented Dec 26, 2020

Stats from current PR

ijjk commented Dec 26, 2020

Stats from current PR

ijjk commented Jan 2, 2021

Stats from current PR

clayrisser commented Jan 8, 2021

ijjk commented Jan 8, 2021

Stats from current PR

timneutkens commented Jan 11, 2021

elliottsj commented Jan 11, 2021

timneutkens commented Jan 11, 2021