Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure i18n context values are provided for blocking 404 #18513

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 30, 2020

This ensures we provide the current locale, locales, and defaultLocale in the context when rendering the 404 for a blocking SSG page

Fixes: #18505

@ijjk
Copy link
Member Author

ijjk commented Oct 30, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
buildDuration 12.3s 12.2s -150ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +240 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
/ failed reqs 0 0
/ total time (seconds) 2.316 2.311 0
/ avg req/sec 1079.41 1081.69 +2.28
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.234 1.21 -0.02
/error-in-render avg req/sec 2026.5 2066.62 +40.12
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-2bc1e97..bed6.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.3 kB 58.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-8cad9cc..dule.js gzip 6.33 kB 6.33 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.1 kB 53.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.75 kB 7.75 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.4 kB 5.4 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 995 B 995 B
Overall change 3.01 kB 3.01 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
buildDuration 14s 14s -59ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +240 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-2bc1e97..bed6.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.3 kB 58.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-8cad9cc..dule.js gzip 6.33 kB 6.33 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.1 kB 53.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.75 kB 7.75 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.4 kB 5.4 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/missing-404-ctx-values Change
_error.js 1.06 MB 1.06 MB ⚠️ +117 B
404.html 4.73 kB 4.73 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB ⚠️ +117 B
link.js 1.11 MB 1.11 MB ⚠️ +117 B
routerDirect.js 1.1 MB 1.1 MB ⚠️ +117 B
withRouter.js 1.1 MB 1.1 MB ⚠️ +117 B
Overall change 5.43 MB 5.43 MB ⚠️ +585 B
Commit: 03bada4

@kodiakhq kodiakhq bot merged commit 4263318 into vercel:canary Oct 30, 2020
@ijjk ijjk deleted the i18n/missing-404-ctx-values branch October 30, 2020 04:06
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[10.0.0][i18n][notFound][Vercel] undefined locale and locales in getStaticProps on custom 404-page
3 participants