Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): add strictPostcssConfiguration flag #20914

Merged
merged 4 commits into from
Jan 11, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 8, 2021

This pull request adds future.strictPostcssConfiguration, allowing users to opt-into the more strict PostCSS configuration loading.

This stricter PostCSS configuration loading ensures that CSS can be cached across builds.

@ijjk ijjk added the type: next label Jan 8, 2021
@ijjk
Copy link
Member

ijjk commented Jan 8, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
buildDuration 10.6s 10.3s -250ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +862 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
/ failed reqs 0 0
/ total time (seconds) 2.076 2.079 0
/ avg req/sec 1204.23 1202.46 ⚠️ -1.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.361 1.271 -0.09
/error-in-render avg req/sec 1836.65 1966.29 +129.64
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
buildDuration 12.5s 12.5s -31ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +862 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 66b9d0a

@Timer Timer force-pushed the feat/strictPostcssConfiguration branch from df8c2f7 to 04773f4 Compare January 8, 2021 22:26
@Timer Timer marked this pull request as ready for review January 8, 2021 22:26
Copy link
Contributor

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a fantastic feature, best feature I've ever seen 👏🏼

@ijjk
Copy link
Member

ijjk commented Jan 8, 2021

Stats from current PR

Default Server Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
buildDuration 9.9s 9.9s -7ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +862 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
/ failed reqs 0 0
/ total time (seconds) 1.956 2.012 ⚠️ +0.06
/ avg req/sec 1278.23 1242.72 ⚠️ -35.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.23 1.208 -0.02
/error-in-render avg req/sec 2032.73 2070.11 +37.38
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
buildDuration 12.1s 12.1s -66ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +862 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 04773f4

@ijjk
Copy link
Member

ijjk commented Jan 10, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
buildDuration 8.6s 8.8s ⚠️ +209ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +862 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
/ failed reqs 0 0
/ total time (seconds) 1.789 1.743 -0.05
/ avg req/sec 1397.31 1434.5 +37.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.102 1.101 0
/error-in-render avg req/sec 2268.25 2271.3 +3.05
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
buildDuration 10.5s 10.2s -259ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +862 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: c7fbbe6

@ijjk
Copy link
Member

ijjk commented Jan 11, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
buildDuration 10.5s 10.6s ⚠️ +141ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +862 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
/ failed reqs 0 0
/ total time (seconds) 2.079 2.14 ⚠️ +0.06
/ avg req/sec 1202.27 1168.32 ⚠️ -33.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.332 1.333 0
/error-in-render avg req/sec 1876.96 1874.78 ⚠️ -2.18
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-9769710..cf61.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
index.html gzip 615 B 615 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
buildDuration 12.7s 12.8s ⚠️ +56ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +862 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-9769710..cf61.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary Timer/next.js feat/strictPostcssConfiguration Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 36ce02b

@kodiakhq kodiakhq bot merged commit d0e2854 into vercel:canary Jan 11, 2021
@Timer Timer deleted the feat/strictPostcssConfiguration branch January 19, 2021 05:34
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants