Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font optimization - Pass nonce to inlined font definition #21346

Merged
merged 21 commits into from
Jan 26, 2021

Conversation

janicklas-ralph
Copy link
Contributor

No description provided.

@ijjk
Copy link
Member

ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
buildDuration 8.8s 8.7s -129ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +471 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
/ failed reqs 0 0
/ total time (seconds) 1.744 1.733 -0.01
/ avg req/sec 1433.3 1442.3 +9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.071 1.075 0
/error-in-render avg req/sec 2334.7 2325.4 ⚠️ -9.3
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
buildDuration 10.2s 10.3s ⚠️ +176ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +471 B
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
_error.js 1 MB 1 MB ⚠️ +141 B
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB ⚠️ +141 B
link.js 1.06 MB 1.06 MB ⚠️ +141 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +141 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +141 B
Overall change 5.19 MB 5.19 MB ⚠️ +705 B

Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
buildDuration 10.6s 10.5s -81ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +471 B
Page Load Tests Overall increase ✓
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
/ failed reqs 0 0
/ total time (seconds) 1.719 1.711 -0.01
/ avg req/sec 1454.02 1460.75 +6.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.233 1.097 -0.14
/error-in-render avg req/sec 2027.89 2279.71 +251.82
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
597-c48889ef..1870.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB
hooks-725de8..0a15.js gzip 904 B 904 B
index-939503..6e1c.js gzip 232 B 232 B
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB
routerDirect..9360.js gzip 308 B 308 B
withRouter-6..44ec.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary janicklas-ralph/next.js font-optimization Change
index.html gzip 587 B 587 B
link.html gzip 591 B 591 B
withRouter.html gzip 580 B 580 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "KgDCm00EMqrB9hUA0cRQA",
+        "buildId": "EWYzqOVqIXihIWMXzr9zm",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/KgDCm00EMqrB9hUA0cRQA/_buildManifest.js"
+      src="/_next/static/EWYzqOVqIXihIWMXzr9zm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/KgDCm00EMqrB9hUA0cRQA/_ssgManifest.js"
+      src="/_next/static/EWYzqOVqIXihIWMXzr9zm/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "KgDCm00EMqrB9hUA0cRQA",
+        "buildId": "EWYzqOVqIXihIWMXzr9zm",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/KgDCm00EMqrB9hUA0cRQA/_buildManifest.js"
+      src="/_next/static/EWYzqOVqIXihIWMXzr9zm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/KgDCm00EMqrB9hUA0cRQA/_ssgManifest.js"
+      src="/_next/static/EWYzqOVqIXihIWMXzr9zm/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "KgDCm00EMqrB9hUA0cRQA",
+        "buildId": "EWYzqOVqIXihIWMXzr9zm",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/KgDCm00EMqrB9hUA0cRQA/_buildManifest.js"
+      src="/_next/static/EWYzqOVqIXihIWMXzr9zm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/KgDCm00EMqrB9hUA0cRQA/_ssgManifest.js"
+      src="/_next/static/EWYzqOVqIXihIWMXzr9zm/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 7a3b6a3

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants