Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load webpack hook before config is required #22583

Merged
merged 7 commits into from
Feb 27, 2021
Merged

fix: load webpack hook before config is required #22583

merged 7 commits into from
Feb 27, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Feb 27, 2021 •
edited
Loading

This pull request ensures the webpack hook is installed before an attempt is made to load the configuration.

This pull request is tested by the PnP tests, which should now be passing as a result of this change.

Fixes #21679

@ijjk
Copy link
Member

ijjk commented Feb 27, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
buildDuration 10.6s 11.3s ⚠️ +669ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +6.07 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.055 2.182 ⚠️ +0.13
/ avg req/sec 1216.76 1145.69 ⚠️ -71.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.458 1.48 ⚠️ +0.02
/error-in-render avg req/sec 1714.86 1689.31 ⚠️ -25.55
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
buildDuration 13.1s 13.5s ⚠️ +363ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +6.07 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
buildDuration 13.2s 13.5s ⚠️ +293ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +6.07 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.041 2.064 ⚠️ +0.02
/ avg req/sec 1224.96 1211.27 ⚠️ -13.69
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.483 1.421 -0.06
/error-in-render avg req/sec 1685.64 1759.12 +73.48
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "XAPia75-MmKFUYy6hxuig",
+        "buildId": "-8J1RqRJATefcVJNXCBmS",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XAPia75-MmKFUYy6hxuig/_buildManifest.js"
+      src="/_next/static/-8J1RqRJATefcVJNXCBmS/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XAPia75-MmKFUYy6hxuig/_ssgManifest.js"
+      src="/_next/static/-8J1RqRJATefcVJNXCBmS/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "XAPia75-MmKFUYy6hxuig",
+        "buildId": "-8J1RqRJATefcVJNXCBmS",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XAPia75-MmKFUYy6hxuig/_buildManifest.js"
+      src="/_next/static/-8J1RqRJATefcVJNXCBmS/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XAPia75-MmKFUYy6hxuig/_ssgManifest.js"
+      src="/_next/static/-8J1RqRJATefcVJNXCBmS/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "XAPia75-MmKFUYy6hxuig",
+        "buildId": "-8J1RqRJATefcVJNXCBmS",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XAPia75-MmKFUYy6hxuig/_buildManifest.js"
+      src="/_next/static/-8J1RqRJATefcVJNXCBmS/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XAPia75-MmKFUYy6hxuig/_ssgManifest.js"
+      src="/_next/static/-8J1RqRJATefcVJNXCBmS/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: b0884ec

@ijjk
Copy link
Member

ijjk commented Feb 27, 2021

Stats from current PR

Default Server Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
buildDuration 12.9s 13.3s ⚠️ +388ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +6.08 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.516 2.464 -0.05
/ avg req/sec 993.57 1014.62 +21.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.711 1.731 ⚠️ +0.02
/error-in-render avg req/sec 1461.43 1443.99 ⚠️ -17.44
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
buildDuration 15.6s 15.6s ⚠️ +48ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +6.08 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
buildDuration 15.5s 15.7s ⚠️ +166ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +6.08 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.396 2.389 -0.01
/ avg req/sec 1043.44 1046.43 +2.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.634 1.733 ⚠️ +0.1
/error-in-render avg req/sec 1530.3 1442.65 ⚠️ -87.65
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack-loading Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "S4mRiW-xarCAoEsnW5hPF",
+        "buildId": "I6ialAHW4ps4W5EuVQ4jv",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/S4mRiW-xarCAoEsnW5hPF/_buildManifest.js"
+      src="/_next/static/I6ialAHW4ps4W5EuVQ4jv/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/S4mRiW-xarCAoEsnW5hPF/_ssgManifest.js"
+      src="/_next/static/I6ialAHW4ps4W5EuVQ4jv/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "S4mRiW-xarCAoEsnW5hPF",
+        "buildId": "I6ialAHW4ps4W5EuVQ4jv",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/S4mRiW-xarCAoEsnW5hPF/_buildManifest.js"
+      src="/_next/static/I6ialAHW4ps4W5EuVQ4jv/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/S4mRiW-xarCAoEsnW5hPF/_ssgManifest.js"
+      src="/_next/static/I6ialAHW4ps4W5EuVQ4jv/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "S4mRiW-xarCAoEsnW5hPF",
+        "buildId": "I6ialAHW4ps4W5EuVQ4jv",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/S4mRiW-xarCAoEsnW5hPF/_buildManifest.js"
+      src="/_next/static/I6ialAHW4ps4W5EuVQ4jv/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/S4mRiW-xarCAoEsnW5hPF/_ssgManifest.js"
+      src="/_next/static/I6ialAHW4ps4W5EuVQ4jv/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 2237855

@Timer Timer marked this pull request as ready for review February 27, 2021 05:32
@kodiakhq kodiakhq bot merged commit 04f37d0 into vercel:canary Feb 27, 2021
@ijjk ijjk deleted the hotfix/webpack-loading branch February 27, 2021 06:19
ghost
ghost reviewed Mar 1, 2021
View reviewed changes
packages/next/next-server/server/config.ts
}
}

const defaultConfig: NextConfig = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal just invalidated the docs, which shouldn't've been pointed to canary anyway: https://nextjs.org/docs/api-reference/next.config.js/introduction

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate more? Those docs are still accurate!

@ijjk ijjk mentioned this pull request Mar 2, 2021
Merged
kodiakhq bot pushed a commit that referenced this pull request Mar 3, 2021
@ijjk
Update webpack server chunks output (#22697)
b80fdfb 
This updates to output server chunks to a nested folder to prevent bundling the entire folder when tracing. This also fixes the webpack 5 tests not actually using webpack 5 since #22583 since the webpack 5 enabling check didn't account for the test environment variable used to enable webpack 5. This also clears up some deprecation warnings from webpack 5 in the mini-css-extract-plugin.

Fixes: #21297
@ijjk ijjk added the type: next label Mar 3, 2021
@ykzts ykzts mentioned this pull request Mar 5, 2021
Merged
@carloscuesta carloscuesta mentioned this pull request Mar 6, 2021
Closed
@callumlocke callumlocke mentioned this pull request May 26, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'webpack'
2 participants
@Timer @ijjk