Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when building a TS project with composite: true and fallback to incremental #35270

Merged
merged 3 commits into from
May 23, 2022

Conversation

ericmatthys
Copy link
Contributor

Related to #26429 and #32755

I wanted to get a temperature check on this before spending more time on it.

I think fully supporting project references and composite: true is a bigger endeavor, but it seems beneficial to at least warn that it is not supported and attempt to fallback to a basic incremental mode. This will allow some monorepos with project references to still type check as part of the build process, depending on how their paths are set up. If it still fails, at least there's more of an indication that it's not fully supported.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Mar 12, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
buildDuration 15.6s 15.4s -139ms
buildDurationCached 6s 6s ⚠️ +26ms
nodeModulesSize 378 MB 378 MB ⚠️ +595 B
Page Load Tests Overall increase ✓
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
/ failed reqs 0 0
/ total time (seconds) 3.101 3.078 -0.02
/ avg req/sec 806.2 812.33 +6.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.329 1.321 -0.01
/error-in-render avg req/sec 1881.41 1892.55 +11.14
Client Bundles (main, webpack)
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
buildDuration 18.7s 18.7s -4ms
buildDurationCached 6.1s 6.1s -38ms
nodeModulesSize 378 MB 378 MB ⚠️ +595 B
Page Load Tests Overall increase ✓
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
/ failed reqs 0 0
/ total time (seconds) 3.09 3.062 -0.03
/ avg req/sec 809.16 816.46 +7.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.333 1.322 -0.01
/error-in-render avg req/sec 1875.28 1890.83 +15.55
Client Bundles (main, webpack)
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.23 kB 5.23 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15 kB 15 kB
Client Build Manifests
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ericmatthys/next.js ts-composite-build Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: a608794

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning for this not being fully supported definitely seems good, thanks!

@ijjk ijjk merged commit 0d80b11 into vercel:canary May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants