-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry: track usage of 'experimental/nextScriptWorkers' #36812
Merged
kodiakhq
merged 4 commits into
vercel:canary
from
housseindjirdeh:telemetry-next-script-workers
May 11, 2022
Merged
Telemetry: track usage of 'experimental/nextScriptWorkers' #36812
kodiakhq
merged 4 commits into
vercel:canary
from
housseindjirdeh:telemetry-next-script-workers
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housseindjirdeh
requested review from
timneutkens,
ijjk,
shuding,
padmaia and
huozhi
as code owners
May 10, 2022 16:21
ijjk
added
created-by: Chrome Aurora
PRs by the Google Chrome team: https://web.dev/aurora
type: next
labels
May 10, 2022
housseindjirdeh
force-pushed
the
telemetry-next-script-workers
branch
from
May 10, 2022 16:22
8212f0d
to
6a9eaa9
Compare
Failing test suitesCommit: a59deda
Expand output● Telemetry CLI › emits telemetry for usage of swc
● Telemetry CLI › emits telemetry for usage of
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
buildDuration | 18.2s | 18.3s | |
buildDurationCached | 7.3s | 7.2s | -38ms |
nodeModulesSize | 475 MB | 475 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 4.554 | 4.562 | |
/ avg req/sec | 549.01 | 547.95 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.55 | 1.544 | -0.01 |
/error-in-render avg req/sec | 1613.14 | 1619.42 | +6.28 |
Client Bundles (main, webpack)
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
925.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42 kB | 42 kB | ✓ |
main-HASH.js gzip | 28.8 kB | 28.8 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 72.5 kB | 72.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.36 kB | 1.36 kB | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 308 B | 308 B | ✓ |
css-HASH.js gzip | 327 B | 327 B | ✓ |
dynamic-HASH.js gzip | 2.69 kB | 2.69 kB | ✓ |
head-HASH.js gzip | 359 B | 359 B | ✓ |
hooks-HASH.js gzip | 920 B | 920 B | ✓ |
image-HASH.js gzip | 5.7 kB | 5.7 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.64 kB | 2.64 kB | ✓ |
routerDirect..HASH.js gzip | 320 B | 320 B | ✓ |
script-HASH.js gzip | 391 B | 391 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 15.9 kB | 15.9 kB | ✓ |
Client Build Manifests
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
index.html gzip | 532 B | 532 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 527 B | 527 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
buildDuration | 20.2s | 19.8s | -458ms |
buildDurationCached | 7s | 7.2s | |
nodeModulesSize | 475 MB | 475 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 4.575 | 4.585 | |
/ avg req/sec | 546.48 | 545.27 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.514 | 1.597 | |
/error-in-render avg req/sec | 1650.72 | 1565.51 |
Client Bundles (main, webpack)
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
925.HASH.js gzip | 178 B | 178 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 29.2 kB | 29.2 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 73.1 kB | 73.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 179 B | 179 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 324 B | 324 B | ✓ |
dynamic-HASH.js gzip | 2.71 kB | 2.71 kB | ✓ |
head-HASH.js gzip | 357 B | 357 B | ✓ |
hooks-HASH.js gzip | 921 B | 921 B | ✓ |
image-HASH.js gzip | 5.79 kB | 5.79 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 2.76 kB | 2.76 kB | ✓ |
routerDirect..HASH.js gzip | 322 B | 322 B | ✓ |
script-HASH.js gzip | 392 B | 392 B | ✓ |
withRouter-HASH.js gzip | 317 B | 317 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 16.1 kB | 16.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
_buildManifest.js gzip | 456 B | 456 B | ✓ |
Overall change | 456 B | 456 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | housseindjirdeh/next.js telemetry-next-script-workers | Change | |
---|---|---|---|
index.html gzip | 530 B | 530 B | ✓ |
link.html gzip | 544 B | 544 B | ✓ |
withRouter.html gzip | 527 B | 527 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
housseindjirdeh
force-pushed
the
telemetry-next-script-workers
branch
3 times, most recently
from
May 11, 2022 15:55
a59deda
to
5c8555b
Compare
housseindjirdeh
force-pushed
the
telemetry-next-script-workers
branch
from
May 11, 2022 15:55
5c8555b
to
ea4ad2c
Compare
ijjk
approved these changes
May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track usage of the experimental
nextScriptWorkers
flag.Backend PR: https://github.com/vercel/next-telemetry/pull/75
https://nextjs.org/docs/basic-features/script#off-loading-scripts-to-a-web-worker-experimental