fix(#36651): disable reactRemoveProperties in jest transform

[SukkaW]

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Fixes #36651.

Always disable reactRemoveProperties in next/jest transformation.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
buildDuration	15s	15s	-23ms
buildDurationCached	6.1s	6.2s	⚠️ +61ms
nodeModulesSize	478 MB	478 MB	⚠️ +216 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.669	3.701	⚠️ +0.03
/ avg req/sec	681.45	675.42	⚠️ -6.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.164	1.132	-0.03
/error-in-render avg req/sec	2148.57	2208.61	+60.04

Client Bundles (main, webpack)

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28.7 kB	28.7 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.4 kB	72.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	308 B	308 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.7 kB	2.7 kB	✓
head-HASH.js gzip	359 B	359 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.71 kB	5.71 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.65 kB	2.65 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	391 B	391 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.9 kB	15.9 kB	✓

Client Build Manifests

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
index.html gzip	532 B	532 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC

General Overall increase ⚠️

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
buildDuration	17.4s	17.3s	-126ms
buildDurationCached	6.1s	6.2s	⚠️ +118ms
nodeModulesSize	478 MB	478 MB	⚠️ +216 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.687	3.704	⚠️ +0.02
/ avg req/sec	678	674.92	⚠️ -3.08
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.136	1.134	0
/error-in-render avg req/sec	2200.86	2204.03	+3.17

Client Bundles (main, webpack)

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.7 kB	42.7 kB	✓
main-HASH.js gzip	29.2 kB	29.2 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	73.5 kB	73.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.89 kB	2.89 kB	✓
head-HASH.js gzip	357 B	357 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.8 kB	5.8 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.77 kB	2.77 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.3 kB	16.3 kB	✓

Client Build Manifests

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
_buildManifest.js gzip	457 B	457 B	✓
Overall change	457 B	457 B	✓

Rendered Page Sizes

	vercel/next.js canary	SukkaW/next.js fix-36651	Change
index.html gzip	532 B	532 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 8897ffa

[balazsorban44]

Could we add a test case?

[SukkaW]

Could we add a test case?

@balazsorban44 When the reactRemoveProperties was first introduced in #31606, there are no test cases regarding Next.js itself being added at all.

Also when reactRemoveProperties was moved out of experiment in #34074, only a test case regarding telemetry was added.

So IMHO any test case should be added in a separate PR instead.

[timneutkens]

Could you add a test for this? You can use test/production/jest/relay/relay-jest.test.ts as a starting point 👍

[SukkaW]

Could you add a test for this? You can use test/production/jest/relay/relay-jest.test.ts as a starting point 👍

Thanks for the info! I will mark the PR as a draft first.

[SukkaW]

cc @timneutkens

The test case has been added.

[timneutkens]

Looks great @SukkaW 💯

[timneutkens]

I think we might want to do the same for styled-components displayName transform, currently it checks for the dev environment but some people might be using the display name is tests.

 styledComponents: nextConfig?.compiler?.styledComponents
      ? {
          displayName: Boolean(development),
        }
      : null,