Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing doc and PR template for examples #37215

Merged
merged 2 commits into from
May 26, 2022

Conversation

balazsorban44
Copy link
Member

Follow-up on #37193

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
  • The examples guidelines are followed from our contributing doc

@ijjk
Copy link
Member

ijjk commented May 26, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js docs/example-contributions Change
buildDuration 15.6s 24.4s ⚠️ +8.8s
buildDurationCached 6.4s 6s -352ms
nodeModulesSize 494 MB 494 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js docs/example-contributions Change
/ failed reqs 0 0
/ total time (seconds) 3.814 5.681 ⚠️ +1.87
/ avg req/sec 655.47 440.09 ⚠️ -215.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.319 3.25 ⚠️ +1.93
/error-in-render avg req/sec 1895.21 769.15 ⚠️ -1126.06
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js docs/example-contributions Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js docs/example-contributions Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js docs/example-contributions Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary vercel/next.js docs/example-contributions Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js docs/example-contributions Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js docs/example-contributions Change
buildDuration 17.5s 18.3s ⚠️ +744ms
buildDurationCached 6.1s 6.1s -1ms
nodeModulesSize 494 MB 494 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js docs/example-contributions Change
/ failed reqs 0 0
/ total time (seconds) 3.8 4.008 ⚠️ +0.21
/ avg req/sec 657.88 623.76 ⚠️ -34.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.282 1.411 ⚠️ +0.13
/error-in-render avg req/sec 1950.24 1772.31 ⚠️ -177.93
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js docs/example-contributions Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js docs/example-contributions Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js docs/example-contributions Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js docs/example-contributions Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js docs/example-contributions Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: f85f155

@kodiakhq kodiakhq bot merged commit 3c764fc into canary May 26, 2022
@kodiakhq kodiakhq bot deleted the docs/example-contributions branch May 26, 2022 15:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants