Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missed yarn -> pnpm in contributing #37370

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Update missed yarn -> pnpm in contributing #37370

merged 2 commits into from
Jun 1, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 1, 2022

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

x-ref: #37369

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jun 1, 2022
@ijjk ijjk marked this pull request as ready for review June 1, 2022 15:35
@ijjk ijjk requested a review from styfle June 1, 2022 15:36
shuding
shuding reviewed Jun 1, 2022
View reviewed changes
contributing.md Outdated Show resolved Hide resolved
@ijjk @shuding
Apply suggestions from code review
b2d6a1f 
Co-authored-by: Shu Ding <g@shud.in>
@ijjk ijjk requested a review from shuding June 1, 2022 15:53
@ijjk ijjk merged commit 1420dd9 into vercel:canary Jun 1, 2022
@ijjk ijjk deleted the docs/yarn-pnpm branch June 1, 2022 15:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@huozhi huozhi Awaiting requested review from huozhi

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @shuding