Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert hello-world example to TypeScript #37706

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Convert hello-world example to TypeScript #37706

merged 3 commits into from
Jun 15, 2022

Conversation

maxproske
Copy link
Contributor

TypeScript is being leveraged for new examples going forward, so I'm converting this example over. 😂

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jun 15, 2022
balazsorban44
balazsorban44 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 💚

@kodiakhq kodiakhq bot merged commit 007d186 into vercel:canary Jun 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxproske @balazsorban44 @ijjk