Exclude srcset
from svg image
#44308
Merged
+14
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior for svg is
dangerouslyAllowSVG: false
which means we won't try to optimize the image because its vector (see #34431 for more).However, svg was incorrectly getting the
srcset
attribute assigned which would contain duplicate information like:So this PR makes sure we treat svg the same as
unoptimized: true
, meaning there is nosrcset
generated. Note that this PR won't change the behavior ifloader
is defined or ifdangerouslyAllowSVG: true
.